Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1944883002: Move ADM Create() method to public interface. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi, noahric
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move ADM Create() method to public interface. ADMs were previously created by CreateAudioDeviceModule which was removed in previous refactoring without a replacement added. BUG= R=tommi@webrtc.org Committed: https://crrev.com/4adbbcfe7a4c7d771b4601130416e5ede4eb3322 Cr-Commit-Position: refs/heads/master@{#12613}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
pbos-webrtc
PTAL, this resolves the public-interface removal in https://codereview.webrtc.org/1477013005.
4 years, 7 months ago (2016-05-03 18:35:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944883002/1
4 years, 7 months ago (2016-05-03 18:38:15 UTC) #3
tommi
lgtm
4 years, 7 months ago (2016-05-03 19:05:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944883002/1
4 years, 7 months ago (2016-05-03 19:19:16 UTC) #8
pbos-webrtc
4 years, 7 months ago (2016-05-03 19:51:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4adbbcfe7a4c7d771b4601130416e5ede4eb3322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698