Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: webrtc/base/virtualsocket_unittest.cc

Issue 1944683002: Read recv timestamps from socket (posix only). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix win build. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/virtualsocket_unittest.cc
diff --git a/webrtc/base/virtualsocket_unittest.cc b/webrtc/base/virtualsocket_unittest.cc
index bdbf06a0e9340ac727ca9d24cea009b67533d006..658421a2c7b9f2e0dc4010857f9cc07e157b17eb 100644
--- a/webrtc/base/virtualsocket_unittest.cc
+++ b/webrtc/base/virtualsocket_unittest.cc
@@ -464,7 +464,8 @@ class VirtualSocketServerTest : public testing::Test {
char buffer[10];
EXPECT_FALSE(sink.Check(b.get(), testing::SSE_READ));
- EXPECT_EQ(-1, b->Recv(buffer, 10));
+ int64_t timestamp;
+ EXPECT_EQ(-1, b->Recv(buffer, 10, &timestamp));
EXPECT_TRUE(sink.Check(a, testing::SSE_CLOSE));
EXPECT_EQ(a->GetState(), AsyncSocket::CS_CLOSED);
@@ -531,7 +532,8 @@ class VirtualSocketServerTest : public testing::Test {
EXPECT_TRUE(a->IsBlocking());
// Read a subset of the data
- result = b->Recv(recv_buffer + recv_pos, 500);
+ int64_t timestamp;
+ result = b->Recv(recv_buffer + recv_pos, 500, &timestamp);
EXPECT_EQ(500, result);
recv_pos += result;
@@ -546,7 +548,8 @@ class VirtualSocketServerTest : public testing::Test {
// Empty the recv buffer
while (true) {
- result = b->Recv(recv_buffer + recv_pos, kDataSize - recv_pos);
+ result =
+ b->Recv(recv_buffer + recv_pos, kDataSize - recv_pos, &timestamp);
if (result < 0) {
EXPECT_EQ(-1, result);
EXPECT_TRUE(b->IsBlocking());
@@ -560,7 +563,8 @@ class VirtualSocketServerTest : public testing::Test {
// Continue to empty the recv buffer
while (true) {
- result = b->Recv(recv_buffer + recv_pos, kDataSize - recv_pos);
+ result =
+ b->Recv(recv_buffer + recv_pos, kDataSize - recv_pos, &timestamp);
if (result < 0) {
EXPECT_EQ(-1, result);
EXPECT_TRUE(b->IsBlocking());
@@ -579,7 +583,8 @@ class VirtualSocketServerTest : public testing::Test {
// Receive the last of the data
while (true) {
- result = b->Recv(recv_buffer + recv_pos, kDataSize - recv_pos);
+ result =
+ b->Recv(recv_buffer + recv_pos, kDataSize - recv_pos, &timestamp);
if (result < 0) {
EXPECT_EQ(-1, result);
EXPECT_TRUE(b->IsBlocking());
@@ -626,7 +631,8 @@ class VirtualSocketServerTest : public testing::Test {
ss_->ProcessMessagesUntilIdle();
for (char i = 0; i < cNumPackets; ++i) {
- EXPECT_EQ(1, b->Recv(buffer, sizeof(buffer)));
+ int64_t timestamp;
+ EXPECT_EQ(1, b->Recv(buffer, sizeof(buffer), &timestamp));
EXPECT_EQ(static_cast<char>('0' + i), buffer[0]);
}
@@ -646,7 +652,8 @@ class VirtualSocketServerTest : public testing::Test {
ss_->ProcessMessagesUntilIdle();
for (char i = 0; i < cNumPackets; ++i) {
- EXPECT_EQ(1, b->Recv(buffer, sizeof(buffer)));
+ int64_t timestamp;
+ EXPECT_EQ(1, b->Recv(buffer, sizeof(buffer), &timestamp));
EXPECT_EQ(static_cast<char>('A' + i), buffer[0]);
}
}

Powered by Google App Engine
This is Rietveld 408576698