Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: webrtc/base/physicalsocketserver_unittest.cc

Issue 1944683002: Read recv timestamps from socket (posix only). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disable ipv6 test on Linux due to bot issues. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/physicalsocketserver.cc ('k') | webrtc/base/proxyserver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/physicalsocketserver_unittest.cc
diff --git a/webrtc/base/physicalsocketserver_unittest.cc b/webrtc/base/physicalsocketserver_unittest.cc
index a04362d919dd1008faeda1f1cfe84729f06471fd..83d2c04fe84b28e4042db4f7bd9d518a91cfa51a 100644
--- a/webrtc/base/physicalsocketserver_unittest.cc
+++ b/webrtc/base/physicalsocketserver_unittest.cc
@@ -428,6 +428,10 @@ TEST_F(PhysicalSocketTest, TestUdpIPv4) {
SocketTest::TestUdpIPv4();
}
+TEST_F(PhysicalSocketTest, TestUdpIpv4Interval) {
+ SocketTest::TestUdpIpv4Interval();
+}
+
// Crashes on Linux. See webrtc:4923.
#if defined(WEBRTC_LINUX)
#define MAYBE_TestUdpIPv6 DISABLED_TestUdpIPv6
@@ -438,6 +442,16 @@ TEST_F(PhysicalSocketTest, MAYBE_TestUdpIPv6) {
SocketTest::TestUdpIPv6();
}
+// Frequently fails to bind() on Linux when running on bots. See webrtc:4923.
+#if defined(WEBRTC_LINUX)
+#define MAYBE_TestUdpIpv6Interval DISABLED_TestUdpIpv6Interval
+#else
+#define MAYBE_TestUdpIpv6Interval TestUdpIpv6Interval
+#endif
+TEST_F(PhysicalSocketTest, MAYBE_TestUdpIpv6Interval) {
+ SocketTest::TestUdpIpv6Interval();
juberti2 2016/05/17 06:41:48 Isn't this handled in socket_unittest already?
+}
+
// Disable for TSan v2, see
// https://code.google.com/p/webrtc/issues/detail?id=3498 for details.
// Also disable for MSan, see:
« no previous file with comments | « webrtc/base/physicalsocketserver.cc ('k') | webrtc/base/proxyserver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698