Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: webrtc/base/socket_unittest.cc

Issue 1944683002: Read recv timestamps from socket (posix only). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Improve test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/socket_unittest.cc
diff --git a/webrtc/base/socket_unittest.cc b/webrtc/base/socket_unittest.cc
index 5f6de42a2f13074a6b96bf9eeec5d8dfd31137c4..4b0afc10952546b7953d427cd3aa3e9852199ddd 100644
--- a/webrtc/base/socket_unittest.cc
+++ b/webrtc/base/socket_unittest.cc
@@ -542,7 +542,7 @@ void SocketTest::ServerCloseInternal(const IPAddress& loopback) {
// Ensure the data can be read.
char buffer[10];
- EXPECT_EQ(1, client->Recv(buffer, sizeof(buffer)));
+ EXPECT_EQ(1, client->Recv(buffer, sizeof(buffer), nullptr));
EXPECT_EQ('a', buffer[0]);
// Now we should close, but the remote address will remain.
@@ -674,7 +674,7 @@ void SocketTest::SocketServerWaitInternal(const IPAddress& loopback) {
// But should signal when process_io is true.
EXPECT_TRUE_WAIT((sink.Check(accepted.get(), testing::SSE_READ)), kTimeout);
- EXPECT_LT(0, accepted->Recv(buf, 1024));
+ EXPECT_LT(0, accepted->Recv(buf, 1024, nullptr));
}
void SocketTest::TcpInternal(const IPAddress& loopback, size_t data_size,
@@ -764,7 +764,7 @@ void SocketTest::TcpInternal(const IPAddress& loopback, size_t data_size,
// Receive as much as we can get in a single recv call.
char recved_data[data_size];
- int recved_size = receiver->Recv(recved_data, data_size);
+ int recved_size = receiver->Recv(recved_data, data_size, nullptr);
if (!recv_called) {
// The first Recv() after getting readability should succeed and receive
@@ -851,7 +851,7 @@ void SocketTest::SingleFlowControlCallbackInternal(const IPAddress& loopback) {
// Pull data.
for (int i = 0; i < sends; ++i) {
- client->Recv(buf, arraysize(buf));
+ client->Recv(buf, arraysize(buf), nullptr);
}
// Expect at least one additional writable callback.
« no previous file with comments | « webrtc/base/socket.h ('k') | webrtc/base/socketadapters.h » ('j') | webrtc/base/testclient.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698