Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: webrtc/build/common.gypi

Issue 1944273002: Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://cod… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 # This file contains common settings for building WebRTC components. 9 # This file contains common settings for building WebRTC components.
10 10
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 'cflags_cc': [ 302 'cflags_cc': [
303 '-Wnon-virtual-dtor', 303 '-Wnon-virtual-dtor',
304 # This is enabled for clang; enable for gcc as well. 304 # This is enabled for clang; enable for gcc as well.
305 '-Woverloaded-virtual', 305 '-Woverloaded-virtual',
306 ], 306 ],
307 }], 307 }],
308 ['clang==1', { 308 ['clang==1', {
309 'cflags': [ 309 'cflags': [
310 '-Wimplicit-fallthrough', 310 '-Wimplicit-fallthrough',
311 '-Wthread-safety', 311 '-Wthread-safety',
312 '-Winconsistent-missing-override',
313 ], 312 ],
314 }], 313 }],
315 ], 314 ],
316 }], 315 }],
317 ['target_arch=="arm64"', { 316 ['target_arch=="arm64"', {
318 'defines': [ 317 'defines': [
319 'WEBRTC_ARCH_ARM64', 318 'WEBRTC_ARCH_ARM64',
320 'WEBRTC_HAS_NEON', 319 'WEBRTC_HAS_NEON',
321 ], 320 ],
322 }], 321 }],
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 # For access to standard POSIXish features, use WEBRTC_POSIX instead 498 # For access to standard POSIXish features, use WEBRTC_POSIX instead
500 # of a more specific macro. 499 # of a more specific macro.
501 'defines': [ 500 'defines': [
502 'WEBRTC_POSIX', 501 'WEBRTC_POSIX',
503 ], 502 ],
504 }], 503 }],
505 ], 504 ],
506 }, 505 },
507 }, # target_defaults 506 }, # target_defaults
508 } 507 }
OLDNEW
« no previous file with comments | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698