Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: webrtc/BUILD.gn

Issue 1944273002: Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://cod… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330. 9 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 # This is enabled for clang; enable for gcc as well. 110 # This is enabled for clang; enable for gcc as well.
111 "-Woverloaded-virtual", 111 "-Woverloaded-virtual",
112 ] 112 ]
113 } 113 }
114 } 114 }
115 115
116 if (is_clang) { 116 if (is_clang) {
117 cflags += [ 117 cflags += [
118 "-Wimplicit-fallthrough", 118 "-Wimplicit-fallthrough",
119 "-Wthread-safety", 119 "-Wthread-safety",
120 "-Winconsistent-missing-override",
121 ] 120 ]
122 } 121 }
123 } 122 }
124 123
125 if (current_cpu == "arm64") { 124 if (current_cpu == "arm64") {
126 defines += [ "WEBRTC_ARCH_ARM64" ] 125 defines += [ "WEBRTC_ARCH_ARM64" ]
127 defines += [ "WEBRTC_HAS_NEON" ] 126 defines += [ "WEBRTC_HAS_NEON" ]
128 } 127 }
129 128
130 if (current_cpu == "arm") { 129 if (current_cpu == "arm") {
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 if (use_libfuzzer || use_drfuzz) { 284 if (use_libfuzzer || use_drfuzz) {
286 # This target is only here for gn to discover fuzzer build targets under 285 # This target is only here for gn to discover fuzzer build targets under
287 # webrtc/test/fuzzers/. 286 # webrtc/test/fuzzers/.
288 group("webrtc_fuzzers_dummy") { 287 group("webrtc_fuzzers_dummy") {
289 testonly = true 288 testonly = true
290 deps = [ 289 deps = [
291 "test/fuzzers:webrtc_fuzzer_main", 290 "test/fuzzers:webrtc_fuzzer_main",
292 ] 291 ]
293 } 292 }
294 } 293 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698