Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1944273002: Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://cod… (Closed)

Created:
4 years, 7 months ago by ivoc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://codereview.webrtc.org/1921653002/ ) Reason for revert: This CL breaks the google3 import (but not the import bot). This partial revert only reverts the build files. A full revert no longer cleanly applies to ToT, so this was done instead. Original issue's description: > Enable -Winconsistent-missing-override flag. > > The problem with gmock is worked around by commenting out any other override declarations in classes using gmock. > > NOPRESUBMIT=True > BUG=webrtc:3970 > > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60 > Cr-Commit-Position: refs/heads/master@{#12563} TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org BUG=webrtc:3970 Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3 Cr-Commit-Position: refs/heads/master@{#12624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944273002/1
4 years, 7 months ago (2016-05-04 08:27:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 09:37:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3 Cr-Commit-Position: refs/heads/master@{#12624}
4 years, 7 months ago (2016-05-04 09:37:52 UTC) #5
mflodman
lgtm
4 years, 7 months ago (2016-05-06 10:22:40 UTC) #6
nisse-webrtc
4 years, 7 months ago (2016-05-10 13:56:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1959353002/ by nisse@webrtc.org.

The reason for reverting is: Should hopefully work better now, after a fix to 
google3.gypi was landed (121474238)..

Powered by Google App Engine
This is Rietveld 408576698