Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: webrtc/p2p/base/port.h

Issue 1944003002: Increase the stun ping interval. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: First Serveral pings are sent at faster rate. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port.h
diff --git a/webrtc/p2p/base/port.h b/webrtc/p2p/base/port.h
index 937f3cd0284f058e12fc6a47848ac0ad8ec98204..f254a6621a243fd724337895cc9fd8fe4441f95f 100644
--- a/webrtc/p2p/base/port.h
+++ b/webrtc/p2p/base/port.h
@@ -591,6 +591,9 @@ class Connection : public CandidatePairInterface,
// response in milliseconds
int64_t last_received() const;
+ // If the connection need to send Ping at fast rate.
pthatcher1 2016/05/27 17:36:31 Ping => pings at fast rate => at a fast rate
Taylor Brandstetter 2016/05/27 20:11:00 also need => needs
+ bool NeedToPingFast();
pthatcher1 2016/05/27 17:36:31 I'd prefer to simply expose pings_sent() as a meth
Taylor Brandstetter 2016/05/27 20:11:00 I agree with this. P2PTransportChannel can have a
+
protected:
enum { MSG_DELETE = 0, MSG_FIRST_AVAILABLE };
@@ -656,6 +659,9 @@ class Connection : public CandidatePairInterface,
int receiving_timeout_;
int64_t time_created_ms_;
+ // Number of pings we have sent.
+ int ping_sent_count_;
+
friend class Port;
friend class ConnectionRequest;
};

Powered by Google App Engine
This is Rietveld 408576698