Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1943193003: Rename OpenH264 frame-type conversion function. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename OpenH264 frame-type conversion function. Also removing default case, so if another frame is added to EVideoFrameType we have to handle it. This will now NOTREACHED on videoFrameTypeInvalid, but videoFrameTypeInvalid shouldn't happen if encoding succeeds, so it should be fine or we should become aware of it. BUG= R=hbos@webrtc.org Committed: https://crrev.com/39a36705ab734914d500b8a0f214ea630d82ab70 Cr-Commit-Position: refs/heads/master@{#12636}

Patch Set 1 #

Patch Set 2 : kEmptyFrame #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
pbos-webrtc
kEmptyFrame
4 years, 7 months ago (2016-05-03 20:01:05 UTC) #1
pbos-webrtc
PTAL
4 years, 7 months ago (2016-05-03 20:02:17 UTC) #2
hbos
lgtm
4 years, 7 months ago (2016-05-04 08:02:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943193003/20001
4 years, 7 months ago (2016-05-04 20:38:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-04 22:38:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943193003/20001
4 years, 7 months ago (2016-05-05 15:07:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 15:09:15 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/39a36705ab734914d500b8a0f214ea630d82ab70 Cr-Commit-Position: refs/heads/master@{#12636}
4 years, 7 months ago (2016-05-05 15:09:24 UTC) #12
pbos-webrtc
4 years, 7 months ago (2016-05-10 17:10:28 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1964913002/ by pbos@webrtc.org.

The reason for reverting is: Speculative revert for perf regression (though not
likely)..

Powered by Google App Engine
This is Rietveld 408576698