Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: webrtc/media/engine/webrtcvoiceengine_unittest.cc

Issue 1943073003: Support RtpEncodingParameters::active in voice engine. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding a DCHECK. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine_unittest.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine_unittest.cc b/webrtc/media/engine/webrtcvoiceengine_unittest.cc
index 9f9ab47242df5f784e6926cac4862c1f035a699d..64bad67928bf2452872c0a11d0d2efcebc4f3529 100644
--- a/webrtc/media/engine/webrtcvoiceengine_unittest.cc
+++ b/webrtc/media/engine/webrtcvoiceengine_unittest.cc
@@ -893,6 +893,26 @@ TEST_F(WebRtcVoiceEngineTestFake,
EXPECT_FALSE(channel_->SetRtpParameters(kSsrc1, parameters));
}
+// Test that a stream will not be sending if its encoding is made
+// inactive through SetRtpParameters.
+TEST_F(WebRtcVoiceEngineTestFake, SetRtpParametersEncodingsActive) {
+ EXPECT_TRUE(SetupSendStream());
+ SetSend(channel_, true);
+ EXPECT_TRUE(GetSendStream(kSsrc1).IsSending());
+ // Get current parameters and change "active" to false.
+ webrtc::RtpParameters parameters = channel_->GetRtpParameters(kSsrc1);
+ ASSERT_EQ(1u, parameters.encodings.size());
+ ASSERT_TRUE(parameters.encodings[0].active);
+ parameters.encodings[0].active = false;
+ EXPECT_TRUE(channel_->SetRtpParameters(kSsrc1, parameters));
+ EXPECT_FALSE(GetSendStream(kSsrc1).IsSending());
+
+ // Now change it back to active and verify we resume sending.
+ parameters.encodings[0].active = true;
+ EXPECT_TRUE(channel_->SetRtpParameters(kSsrc1, parameters));
+ EXPECT_TRUE(GetSendStream(kSsrc1).IsSending());
+}
+
// Test that SetRtpParameters configures the correct encoding channel for each
// SSRC.
TEST_F(WebRtcVoiceEngineTestFake, RtpParametersArePerStream) {
« webrtc/media/engine/webrtcvoiceengine.cc ('K') | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698