Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943073003: Support RtpEncodingParameters::active in voice engine. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Support RtpEncodingParameters::active in voice engine. R=solenberg@webrtc.org Committed: https://crrev.com/55dd70842c3d2741b08da8e2807cc233ee797ccc Cr-Commit-Position: refs/heads/master@{#12615}

Patch Set 1 #

Patch Set 2 : Adding a DCHECK. #

Total comments: 1

Patch Set 3 : Using DCHECK_EQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
PTAL. This is very simple, just a mirror of what WebRtcVideoEngine2 already does.
4 years, 7 months ago (2016-05-02 23:33:59 UTC) #2
the sun
lgtm https://codereview.webrtc.org/1943073003/diff/20001/webrtc/media/engine/webrtcvoiceengine.cc File webrtc/media/engine/webrtcvoiceengine.cc (right): https://codereview.webrtc.org/1943073003/diff/20001/webrtc/media/engine/webrtcvoiceengine.cc#newcode1229 webrtc/media/engine/webrtcvoiceengine.cc:1229: RTC_DCHECK(rtp_parameters_.encodings.size() == 1u); nit: use .._EQ like above
4 years, 7 months ago (2016-05-03 08:14:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943073003/40001
4 years, 7 months ago (2016-05-03 17:22:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-03 19:23:36 UTC) #8
Taylor Brandstetter
4 years, 7 months ago (2016-05-03 20:50:31 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
55dd70842c3d2741b08da8e2807cc233ee797ccc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698