webrtc/modules/video_coding/video_receiver.cc - Issue 1942683003: Jitter delay now depend on protection mode (FEC/NACK).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_receiver.cc

Issue 1942683003: Jitter delay now depend on protection mode (FEC/NACK). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comment fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/video_coding/video_receiver.cc

diff --git a/webrtc/modules/video_coding/video_receiver.cc b/webrtc/modules/video_coding/video_receiver.cc

index 721c35d2bd36cabf4a766b4723386bdedb0119af..a832e2180b922966a2487e0f1133bf6b7f139df4 100644

--- a/webrtc/modules/video_coding/video_receiver.cc

+++ b/webrtc/modules/video_coding/video_receiver.cc

@@ -168,7 +168,9 @@ int32_t VideoReceiver::SetVideoProtection(VCMVideoProtection videoProtection,

case kProtectionNackFEC: {

rtc::CritScope cs(&receive_crit_);

RTC_DCHECK(enable);

- _receiver.SetNackMode(kNack, media_optimization::kLowRttNackMs, -1);

+ _receiver.SetNackMode(kNack,

+ media_optimization::kLowRttNackMs,

+ media_optimization::kMaxRttDelayThreshold);

_receiver.SetDecodeErrorMode(kNoErrors);

break;

}

« no previous file with comments | « webrtc/modules/video_coding/media_opt_util.h ('k') | webrtc/video/rtp_stream_receiver.cc » ('j') | no next file with comments »