Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Side by Side Diff: webrtc/video/video_receive_stream.cc

Issue 1942683003: Jitter delay now depend on protection mode (FEC/NACK). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 RTC_DCHECK(process_thread_); 181 RTC_DCHECK(process_thread_);
182 RTC_DCHECK(congestion_controller_); 182 RTC_DCHECK(congestion_controller_);
183 RTC_DCHECK(call_stats_); 183 RTC_DCHECK(call_stats_);
184 RTC_DCHECK(remb_); 184 RTC_DCHECK(remb_);
185 RTC_CHECK(vie_channel_.Init() == 0); 185 RTC_CHECK(vie_channel_.Init() == 0);
186 186
187 // Register the channel to receive stats updates. 187 // Register the channel to receive stats updates.
188 call_stats_->RegisterStatsObserver(vie_channel_.GetStatsObserver()); 188 call_stats_->RegisterStatsObserver(vie_channel_.GetStatsObserver());
189 189
190 // TODO(pbos): This is not fine grained enough... 190 // TODO(pbos): This is not fine grained enough...
191 vie_channel_.SetProtectionMode(config_.rtp.nack.rtp_history_ms > 0, false, -1, 191 vie_channel_.SetProtectionMode(config_.rtp.nack.rtp_history_ms > 0,
stefan-webrtc 2016/05/04 09:30:48 I think you may have to rebase this as mflodman ch
philipel 2016/05/04 10:56:05 Talked to Magnus and there is still some refactori
192 -1); 192 config_.rtp.fec.ulpfec_payload_type != -1,
193 config_.rtp.fec.red_payload_type,
194 config_.rtp.fec.ulpfec_payload_type);
193 RTC_DCHECK(config_.rtp.rtcp_mode != RtcpMode::kOff) 195 RTC_DCHECK(config_.rtp.rtcp_mode != RtcpMode::kOff)
194 << "A stream should not be configured with RTCP disabled. This value is " 196 << "A stream should not be configured with RTCP disabled. This value is "
195 "reserved for internal usage."; 197 "reserved for internal usage.";
196 rtp_rtcp_->SetRTCPStatus(config_.rtp.rtcp_mode); 198 rtp_rtcp_->SetRTCPStatus(config_.rtp.rtcp_mode);
197 199
198 RTC_DCHECK(config_.rtp.remote_ssrc != 0); 200 RTC_DCHECK(config_.rtp.remote_ssrc != 0);
199 // TODO(pbos): What's an appropriate local_ssrc for receive-only streams? 201 // TODO(pbos): What's an appropriate local_ssrc for receive-only streams?
200 RTC_DCHECK(config_.rtp.local_ssrc != 0); 202 RTC_DCHECK(config_.rtp.local_ssrc != 0);
201 RTC_DCHECK(config_.rtp.remote_ssrc != config_.rtp.local_ssrc); 203 RTC_DCHECK(config_.rtp.remote_ssrc != config_.rtp.local_ssrc);
202 rtp_rtcp_->SetSSRC(config_.rtp.local_ssrc); 204 rtp_rtcp_->SetSSRC(config_.rtp.local_ssrc);
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 const std::vector<uint16_t>& sequence_numbers) { 442 const std::vector<uint16_t>& sequence_numbers) {
441 rtp_rtcp_->SendNack(sequence_numbers); 443 rtp_rtcp_->SendNack(sequence_numbers);
442 } 444 }
443 445
444 void VideoReceiveStream::RequestKeyFrame() { 446 void VideoReceiveStream::RequestKeyFrame() {
445 rtp_rtcp_->RequestKeyFrame(); 447 rtp_rtcp_->RequestKeyFrame();
446 } 448 }
447 449
448 } // namespace internal 450 } // namespace internal
449 } // namespace webrtc 451 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698