Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

Issue 1942193002: AudioEncoderOpus: Default to 32 kbit/s for mono, 64 kbit/s for stereo (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h
diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h
index 8900659f48eb812ca6b214b481daac16e808e8ff..367c9b90eae5421424683a8f6ece8f919ed02de8 100644
--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h
+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h
@@ -14,6 +14,7 @@
#include <vector>
#include "webrtc/base/constructormagic.h"
+#include "webrtc/base/optional.h"
#include "webrtc/modules/audio_coding/codecs/opus/opus_interface.h"
#include "webrtc/modules/audio_coding/codecs/audio_encoder.h"
@@ -29,12 +30,19 @@ class AudioEncoderOpus final : public AudioEncoder {
};
struct Config {
+ Config();
+ Config(const Config&);
+ ~Config();
+ Config& operator=(const Config&);
+
bool IsOk() const;
+ int GetBitrateBps() const;
+
int frame_size_ms = 20;
size_t num_channels = 1;
int payload_type = 120;
ApplicationMode application = kVoip;
- int bitrate_bps = 64000;
+ rtc::Optional<int> bitrate_bps; // Unset means to use default value.
bool fec_enabled = false;
int max_playback_rate_hz = 48000;
int complexity = kDefaultComplexity;

Powered by Google App Engine
This is Rietveld 408576698