AudioEncoderOpus: Default to 32 kbit/s for mono, 64 kbit/s for stereo

AudioEncoderOpus: Default to 32 kbit/s for mono, 64 kbit/s for stereo

When this class was created, we inadvertently set the default to 64
kbit/s for both cases, failing to preserve the previous behavior. This
patch restores the old behavior.

From what I've been able to dig up, this problem did not affect Opus
encoders created internally in the Audio Coding Module. Those have
always used the bitrate from the supplied CodecInst.

Committed: https://crrev.com/20361356200cacd47682b7307eb68ed9127e3f8b
Cr-Commit-Position: refs/heads/master@{#12827}

[kwiberg-webrtc, 2016-05-03 09:55:35]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-05-17 12:30:32]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2016-05-17 12:31:40]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2016-05-17 12:31:40]

I'd forgotten to send this one out for review.

[hlundin-webrtc, 2016-05-18 00:34:47]

lgtm

https://codereview.webrtc.org/1942193002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc (right):

https://codereview.webrtc.org/1942193002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc:84: auto
AudioEncoderOpus::Config::operator=(const Config&) -> Config& = default;
I don't understand this syntax. Please, educate me.

[kwiberg-webrtc, 2016-05-18 02:54:28]

https://codereview.webrtc.org/1942193002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc (right):

https://codereview.webrtc.org/1942193002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc:84: auto
AudioEncoderOpus::Config::operator=(const Config&) -> Config& = default;
On 2016/05/18 00:34:47, hlundin-webrtc wrote:
> I don't understand this syntax. Please, educate me.

It's a trailing return type (see
http://en.cppreference.com/w/cpp/language/function, and search for "trailing").
I'm surprised you haven't heard of it---it's an often used feature that's been
on the Chromium C++11 allowed language features list for almost a week now!

The advantage of using it here is that I get to call the return type Config&
instead of AudioEncoderOpus::Config&, which prevents a line break, making things
much easier to read.

[kwiberg-webrtc, 2016-05-19 12:49:08]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-05-19 12:49:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942193002/40001

[commit-bot: I haz the power, 2016-05-19 14:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 14:49:55]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-05-20 11:37:18]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-05-20 11:37:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942193002/40001

[commit-bot: I haz the power, 2016-05-20 11:57:05]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-05-20 11:57:15]

Description was changed from

==========
AudioEncoderOpus: Default to 32 kbit/s for mono, 64 kbit/s for stereo

When this class was created, we inadvertently set the default to 64
kbit/s for both cases, failing to preserve the previous behavior. This
patch restores the old behavior.

From what I've been able to dig up, this problem did not affect Opus
encoders created internally in the Audio Coding Module. Those have
always used the bitrate from the supplied CodecInst.
==========

to

==========
AudioEncoderOpus: Default to 32 kbit/s for mono, 64 kbit/s for stereo

When this class was created, we inadvertently set the default to 64
kbit/s for both cases, failing to preserve the previous behavior. This
patch restores the old behavior.

From what I've been able to dig up, this problem did not affect Opus
encoders created internally in the Audio Coding Module. Those have
always used the bitrate from the supplied CodecInst.

Committed: https://crrev.com/20361356200cacd47682b7307eb68ed9127e3f8b
Cr-Commit-Position: refs/heads/master@{#12827}
==========

[commit-bot: I haz the power, 2016-05-20 11:57:16]

Patchset 1 (id:??) landed as
https://crrev.com/20361356200cacd47682b7307eb68ed9127e3f8b
Cr-Commit-Position: refs/heads/master@{#12827}