Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 1942183002: Change aggregation window of aecDivergentFilterFraction to 1 second. (Closed)

Created:
4 years, 7 months ago by minyue-webrtc
Modified:
4 years, 7 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change aggregation window of aecDivergentFilterFraction to 1 second. BUG= Committed: https://crrev.com/3815655541b2d55972a45f09036e78497201249a Cr-Commit-Position: refs/heads/master@{#12617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
minyue-webrtc
Per, Would you review this small CL?
4 years, 7 months ago (2016-05-03 08:57:30 UTC) #3
peah-webrtc
On 2016/05/03 08:57:30, minyue-webrtc wrote: > Per, > > Would you review this small CL? ...
4 years, 7 months ago (2016-05-03 11:26:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942183002/1
4 years, 7 months ago (2016-05-03 11:35:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-03 13:36:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942183002/1
4 years, 7 months ago (2016-05-03 20:31:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 21:42:46 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:42:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3815655541b2d55972a45f09036e78497201249a
Cr-Commit-Position: refs/heads/master@{#12617}

Powered by Google App Engine
This is Rietveld 408576698