Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1941643002: Reland of move VCMQmRobustness. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move VCMQmRobustness. (patchset #1 id:1 of https://codereview.webrtc.org/1935753002/ ) Reason for revert: Not root cause for perf regression (regression still ongoing). Original issue's description: > Revert of Remove VCMQmRobustness. (patchset #1 id:1 of https://codereview.webrtc.org/1917083003/ ) > > Reason for revert: > Speculative revert for perf regression. > > Original issue's description: > > Remove VCMQmRobustness. > > > > Class contained a lot of not-really-wired-up functionality that ended up > > being complicated ways of saying return 1; or return false;. This > > removes this dependency that complicates code readability significantly. > > > > BUG=webrtc:5066 > > R=marpan@google.com, marpan@webrtc.org > > TBR=stefan@webrtc.org > > > > Committed: https://crrev.com/73894369791cb5eedc8788baf918ec07d11d351d > > Cr-Commit-Position: refs/heads/master@{#12516} > > TBR=marpan@webrtc.org,stefan@webrtc.org,marpan@google.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5066, chromium:607838 > > Committed: https://crrev.com/602316c3cd8556cc78d44f3ea4cd5fc8e70d9417 > Cr-Commit-Position: refs/heads/master@{#12572} TBR=marpan@webrtc.org,stefan@webrtc.org,marpan@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5066, chromium:607838 Committed: https://crrev.com/c04305200ecca57c704b623941a808c03489a20a Cr-Commit-Position: refs/heads/master@{#12583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -135 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.cc View 3 chunks +1 line, -28 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/qm_select.h View 1 chunk +0 lines, -30 lines 0 comments Download
M webrtc/modules/video_coding/qm_select.cc View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
pbos-webrtc
Created Reland of move VCMQmRobustness.
4 years, 7 months ago (2016-05-01 23:19:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941643002/1
4 years, 7 months ago (2016-05-01 23:19:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941643002/1
4 years, 7 months ago (2016-05-01 23:31:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941643002/1
4 years, 7 months ago (2016-05-02 00:02:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 00:19:10 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 00:19:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c04305200ecca57c704b623941a808c03489a20a
Cr-Commit-Position: refs/heads/master@{#12583}

Powered by Google App Engine
This is Rietveld 408576698