Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1941413002: Adding in objc vars for WebRTC GN config. (Closed)

Created:
4 years, 7 months ago by phoglund
Modified:
4 years, 7 months ago
Reviewers:
ivoc, kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build_overrides/gtest.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
phoglund
4 years, 7 months ago (2016-05-03 11:44:16 UTC) #1
ivoc
LGTM.
4 years, 7 months ago (2016-05-03 12:06:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941413002/1
4 years, 7 months ago (2016-05-03 12:34:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 7 months ago (2016-05-03 14:35:41 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/87f8c0d07253a0be5b0c4579dc98e26762bec019 Cr-Commit-Position: refs/heads/master@{#12609}
4 years, 7 months ago (2016-05-03 15:20:08 UTC) #11
phoglund
Committed patchset #1 (id:1) manually as 87f8c0d07253a0be5b0c4579dc98e26762bec019 (presubmit successful).
4 years, 7 months ago (2016-05-03 15:20:09 UTC) #13
kjellander_webrtc
4 years, 7 months ago (2016-05-11 07:39:36 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698