Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 7 months ago by phoglund Modified:
4 years, 7 months ago Reviewers:
ivoc, kjellander_webrtc CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdding in objc vars for WebRTC GN config.
Appears to be needed after https://codereview.chromium.org/1941053002.
R=ivoc@webrtc.org
TBR=kjellander@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/87f8c0d07253a0be5b0c4579dc98e26762bec019
Patch Set 1 #
Created: 4 years, 7 months ago
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Adding in objc vars for WebRTC GN config. Appears to be needed after https://codereview.chromium.org/1941053002. R=ivoc@webrtc.org ========== to ========== Adding in objc vars for WebRTC GN config. Appears to be needed after https://codereview.chromium.org/1941053002. R=ivoc@webrtc.org TBR=kjellander@webrtc.org ==========
phoglund@webrtc.org changed reviewers: + kjellander@webrtc.org
ivoc@webrtc.org changed reviewers: - kjellander@webrtc.org
LGTM.
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941413002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Message was sent while issue was closed.
Description was changed from ========== Adding in objc vars for WebRTC GN config. Appears to be needed after https://codereview.chromium.org/1941053002. R=ivoc@webrtc.org TBR=kjellander@webrtc.org ========== to ========== Adding in objc vars for WebRTC GN config. Appears to be needed after https://codereview.chromium.org/1941053002. R=ivoc@webrtc.org TBR=kjellander@webrtc.org Committed: https://crrev.com/87f8c0d07253a0be5b0c4579dc98e26762bec019 Cr-Commit-Position: refs/heads/master@{#12609} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/87f8c0d07253a0be5b0c4579dc98e26762bec019 Cr-Commit-Position: refs/heads/master@{#12609}
Message was sent while issue was closed.
Description was changed from ========== Adding in objc vars for WebRTC GN config. Appears to be needed after https://codereview.chromium.org/1941053002. R=ivoc@webrtc.org TBR=kjellander@webrtc.org Committed: https://crrev.com/87f8c0d07253a0be5b0c4579dc98e26762bec019 Cr-Commit-Position: refs/heads/master@{#12609} ========== to ========== Adding in objc vars for WebRTC GN config. Appears to be needed after https://codereview.chromium.org/1941053002. R=ivoc@webrtc.org TBR=kjellander@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/87f8c0d07253a0be5b0c4579d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 87f8c0d07253a0be5b0c4579dc98e26762bec019 (presubmit successful).
Message was sent while issue was closed.
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
