Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1940933002: Removing unused resources from build files. (Closed)

Created:
4 years, 7 months ago by minyue-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing unused resources from building files. A number of resources files have been removed in https://codereview.webrtc.org/1928923002/ This CL remove the them from the building files. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/modules/modules_unittests.isolate View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
minyue-webrtc
Hi Tommi, Would you take a look?
4 years, 7 months ago (2016-05-02 14:51:39 UTC) #3
tommi
lgtm
4 years, 7 months ago (2016-05-02 15:34:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940933002/1
4 years, 7 months ago (2016-05-02 15:34:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-02 17:34:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940933002/1
4 years, 7 months ago (2016-05-02 18:53:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 19:10:24 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/acf143128fa0d5c728742f3018e075bcec35ae20 Cr-Commit-Position: refs/heads/master@{#12597}
4 years, 7 months ago (2016-05-02 19:10:25 UTC) #15
kjellander_webrtc
4 years, 7 months ago (2016-05-06 20:00:20 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698