Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: webrtc/api/statstypes.cc

Issue 1940493002: Add Stats to Stun ping. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add three more counters for stun ping. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/statstypes.cc
diff --git a/webrtc/api/statstypes.cc b/webrtc/api/statstypes.cc
index 61af82467a7595b2ff255726bd2d53a334839fa5..bde7dcb24ebb739073dd3262862483f12f96ff59 100644
--- a/webrtc/api/statstypes.cc
+++ b/webrtc/api/statstypes.cc
@@ -414,6 +414,18 @@ const char* StatsReport::Value::display_name() const {
return "googBucketDelay";
case kStatsValueNameBandwidthLimitedResolution:
return "googBandwidthLimitedResolution";
+ // STUN ping related attributes.
+ // TODO(zhihuang) Rename these stats to follow the standards.
+ case kStatsValueNameSentPingRequestsTotal:
+ return "consentRequestsSent";
pthatcher1 2016/05/27 21:27:15 I think it's more likely this will end up "request
zhihuang1 2016/06/01 21:30:05 Then I will keep the TODO part.
+ case kStatsValueNameSentPingRequestsBeforeFirstResponse:
+ return "consentRequestsSentBeforeFirstResponse";
pthatcher1 2016/05/27 21:27:15 And this might be "consentRequestsSent".
+ case kStatsValueNameSentPingResponses:
+ return "consentResponsesSent";
+ case kStatsValueNameRecvPingRequests:
+ return "consentRequestsReceived";
+ case kStatsValueNameRecvPingResponses:
+ return "consentResponsesReceived";
// Candidate related attributes. Values are taken from
// http://w3c.github.io/webrtc-stats/#rtcstatstype-enum*.

Powered by Google App Engine
This is Rietveld 408576698