Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: webrtc/p2p/base/port_unittest.cc

Issue 1940493002: Add Stats to Stun ping. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port_unittest.cc
diff --git a/webrtc/p2p/base/port_unittest.cc b/webrtc/p2p/base/port_unittest.cc
index 7e787e08eb316c24053efdcf6dc39a21891db446..8380237ff652b0d654e152bef529d9762a0dcc95 100644
--- a/webrtc/p2p/base/port_unittest.cc
+++ b/webrtc/p2p/base/port_unittest.cc
@@ -1652,7 +1652,12 @@ TEST_F(PortTest, TestSendStunMessage) {
msg = rport->last_stun_msg();
ASSERT_TRUE(msg != NULL);
EXPECT_EQ(STUN_BINDING_RESPONSE, msg->type());
-
+ // Received a BINDING-RESPONSE.
+ lconn->OnReadPacket(rport->last_stun_buf()->data<char>(),
+ rport->last_stun_buf()->size(), rtc::PacketTime());
+ // Verify the STUN Stats.
+ EXPECT_EQ(1U, lconn->sent_ping_requests());
+ EXPECT_EQ(1U, lconn->recv_ping_responses());
EXPECT_FALSE(msg->IsLegacy());
const StunAddressAttribute* addr_attr = msg->GetAddress(
@@ -1723,6 +1728,7 @@ TEST_F(PortTest, TestSendStunMessage) {
msg->GetUInt32(STUN_ATTR_RETRANSMIT_COUNT);
ASSERT_TRUE(retransmit_attr != NULL);
EXPECT_EQ(2U, retransmit_attr->value());
+ EXPECT_EQ(3U, rconn->sent_ping_requests());
// Respond with a BINDING-RESPONSE.
request.reset(CopyStunMessage(msg));

Powered by Google App Engine
This is Rietveld 408576698