Add Stats to Stun ping.

webrtc/p2p/base/port.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 457 matching lines @@
 
   // Estimate of the round-trip time over this connection.
   int rtt() const { return rtt_; }
 
   size_t sent_total_bytes();
   size_t sent_bytes_second();
   // Used to track how many packets are discarded in the application socket due
   // to errors.
   size_t sent_discarded_packets();
   size_t sent_total_packets();
+  size_t sent_ping_requests_total();
+  size_t sent_ping_requests_before_first_response();
+  size_t sent_ping_responses();
   size_t recv_total_bytes();
   size_t recv_bytes_second();
+  size_t recv_ping_responses();
+  size_t recv_ping_requests();
   sigslot::signal1<Connection*> SignalStateChange;
 
   // Sent when the connection has decided that it is no longer of value.  It
   // will delete itself immediately after this call.
   sigslot::signal1<Connection*> SignalDestroyed;
 
   // The connection can send and receive packets asynchronously.  This matches
   // the interface of AsyncPacketSocket, which may use UDP or TCP under the
   // covers.
   virtual int Send(const void* data, size_t size,
@@ skipping 148 matching lines @@
   int64_t last_ping_received_;  // last time we received a ping from the other
                                 // side
   int64_t last_data_received_;
   int64_t last_ping_response_received_;
   std::vector<SentPing> pings_since_last_response_;
 
   rtc::RateTracker recv_rate_tracker_;
   rtc::RateTracker send_rate_tracker_;
   uint32_t sent_packets_discarded_;
   uint32_t sent_packets_total_;
+  // Stun ping related stats.
+  uint32_t sent_ping_requests_total_;
+  uint32_t sent_ping_requests_before_first_response_;
+  uint32_t sent_ping_responses_;
+  uint32_t recv_ping_requests_;
+  uint32_t recv_ping_responses_;

[pthatcher1, 2016/05/27 21:27:15]

Can we just store a ConnectionInfo value here instead?  That would avoid a lot
of duplication, and let us reduce the number of methods down to like info() or
stats() (I think we should rename it to IceCandidatePairStats).

[zhihuang1, 2016/06/01 21:30:05]

Do you mean renaming ConnectionInfo -> IceCandidatePairStats? Should I do it in
this CL or in a seperate CL?

[pthatcher1, 2016/06/01 21:39:48]

In a separate CL is fine.

 
  private:
   void MaybeAddPrflxCandidate(ConnectionRequest* request,
                               StunMessage* response);
 
   bool reported_;
   State state_;
   // Time duration to switch from receiving to not receiving.
   int receiving_timeout_;
   int64_t time_created_ms_;
+  bool received_first_response_;

[pthatcher1, 2016/05/27 21:27:15]

Can you tell by "recv_ping_reponses_ > 0"?

 
   friend class Port;
   friend class ConnectionRequest;
 };
 
 // ProxyConnection defers all the interesting work to the port.
 class ProxyConnection : public Connection {
  public:
   ProxyConnection(Port* port, size_t index, const Candidate& remote_candidate);
 
   int Send(const void* data,
            size_t size,
            const rtc::PacketOptions& options) override;
   int GetError() override { return error_; }
 
  private:
   int error_ = 0;
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_PORT_H_