Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1937983002: Added flag for FEC for video_loopback. (Closed)

Created:
4 years, 7 months ago by philipel
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added flag for FEC for video_loopback. Committed: https://crrev.com/274c1dc545c315bd24d6f778798028ec661749ef Cr-Commit-Position: refs/heads/master@{#12626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M webrtc/video/video_loopback.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipel
4 years, 7 months ago (2016-05-02 15:17:32 UTC) #2
pbos-webrtc
Drive-by: Should this go into screenshare_loopback.cc as well? Can you check with sprang@ if we ...
4 years, 7 months ago (2016-05-02 16:18:02 UTC) #4
stefan-webrtc
lgtm
4 years, 7 months ago (2016-05-04 09:25:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937983002/1
4 years, 7 months ago (2016-05-04 10:56:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 13:21:06 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 13:21:20 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/274c1dc545c315bd24d6f778798028ec661749ef
Cr-Commit-Position: refs/heads/master@{#12626}

Powered by Google App Engine
This is Rietveld 408576698