Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1937933002: Android EGL: Synchronize calls to eglCreateContext (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android EGL: Synchronize calls to eglCreateContext Synchronize calls to EGL10/EGL14.eglCreateContext on EglBase.lock. The reason is that a deadlock between the remote render thread in eglSwapBuffers and MediaCodecVideoEncoder eglCreateContext was observed. The function calls that are now synchronized on EglBase.lock are: eglCreateContext, eglMakeCurrent, eglSwapBuffers, and SurfaceTexture.updateTexImage. BUG=webrtc:5702 Committed: https://crrev.com/ddf165393fcb6ba9b7e7c0219852b5247d1937ed Cr-Commit-Position: refs/heads/master@{#12603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M webrtc/api/java/android/org/webrtc/EglBase10.java View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/EglBase14.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
magjed_webrtc
Alex - Please take a look.
4 years, 7 months ago (2016-05-02 14:00:52 UTC) #3
AlexG
lgtm May be also consider synchronizing all EGL14 calls in future CL - eglCreateWindowSurface, eglCreatePbufferSurface ...
4 years, 7 months ago (2016-05-02 17:16:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937933002/1
4 years, 7 months ago (2016-05-03 07:51:30 UTC) #6
magjed_webrtc
On 2016/05/02 17:16:26, AlexG wrote: > lgtm > > May be also consider synchronizing all ...
4 years, 7 months ago (2016-05-03 07:52:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 08:24:42 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 08:24:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddf165393fcb6ba9b7e7c0219852b5247d1937ed
Cr-Commit-Position: refs/heads/master@{#12603}

Powered by Google App Engine
This is Rietveld 408576698