Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1937153002: Revert of Disable failing modules_unittests for UBSan. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Disable failing modules_unittests for UBSan. (patchset #1 id:40001 of https://codereview.webrtc.org/1915813002/ ) Reason for revert: Fix upstream should've landed in our repository. Original issue's description: > Disable failing modules_unittests for UBSan. > > BUG=webrtc:5820 > TBR=pbos@webrtc.org > > Committed: https://crrev.com/c23bf2e54d922486254cdd7657aafceaa958ce25 > Cr-Commit-Position: refs/heads/master@{#12482} TBR=kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5820 Committed: https://crrev.com/c7a6569713699df07e3a717778014bcc8eff97b3 Cr-Commit-Position: refs/heads/master@{#12647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -41 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 2 chunks +9 lines, -33 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
pbos-webrtc
Created Revert of Disable failing modules_unittests for UBSan.
4 years, 7 months ago (2016-05-02 16:23:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-02 16:23:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-02 16:31:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-02 17:01:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-02 17:32:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-02 18:01:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-02 18:23:59 UTC) #8
ivoc
On 2016/05/02 18:23:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-06 09:32:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-06 16:06:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-06 18:06:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937153002/1
4 years, 7 months ago (2016-05-06 18:10:30 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 19:50:09 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:50:15 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7a6569713699df07e3a717778014bcc8eff97b3
Cr-Commit-Position: refs/heads/master@{#12647}

Powered by Google App Engine
This is Rietveld 408576698