Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 1936503002: Removed SSRC knowledge from ViEEncoder. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@move_payload_router2
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 35a050650337269576322a86fe6dedc31df9cd96..7a972d4e725ba9dd0a591d27f11cf9841463f347 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -24,6 +24,7 @@
#include "webrtc/modules/pacing/packet_router.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
#include "webrtc/modules/utility/include/process_thread.h"
+#include "webrtc/modules/video_coding/utility/ivf_file_writer.h"
#include "webrtc/video/call_stats.h"
#include "webrtc/video/video_capture_input.h"
#include "webrtc/video/vie_remb.h"
@@ -373,7 +374,6 @@ VideoSendStream::VideoSendStream(
config.post_encode_callback,
&stats_proxy_),
vie_encoder_(num_cpu_cores,
- config_.rtp.ssrcs,
module_process_thread_,
&stats_proxy_,
config.pre_encode_callback,
@@ -545,6 +545,13 @@ void VideoSendStream::EncoderProcess() {
vie_encoder_.SetEncoder(encoder_settings->video_codec,
encoder_settings->min_transmit_bitrate_bps,
payload_router_.MaxPayloadLength(), this);
+
+ // Clear stats for disabled layers.
+ for (size_t i = encoder_settings->streams.size();
+ i < config_.rtp.ssrcs.size(); ++i) {
+ stats_proxy_.OnInactiveSsrc(config_.rtp.ssrcs[i]);
+ }
+
if (config_.suspend_below_min_bitrate) {
video_sender_->SuspendBelowMinBitrate();
bitrate_allocator_->EnforceMinBitrate(false);
@@ -605,8 +612,33 @@ int32_t VideoSendStream::Encoded(const EncodedImage& encoded_image,
// |encoded_frame_proxy_| forwards frames to |config_.post_encode_callback|;
encoded_frame_proxy_.Encoded(encoded_image, codec_specific_info,
fragmentation);
- return payload_router_.Encoded(encoded_image, codec_specific_info,
- fragmentation);
+ bool return_value = payload_router_.Encoded(
pbos-webrtc 2016/05/02 01:06:46 eh, no, this should be int32_t, ignore comment bel
perkj_webrtc 2016/05/03 10:22:40 Done.
+ encoded_image, codec_specific_info, fragmentation);
pbos-webrtc 2016/05/02 01:06:11 == 0
+
+ if (kEnableFrameRecording) {
+ int layer = codec_specific_info->codecType == kVideoCodecVP8
+ ? codec_specific_info->codecSpecific.VP8.simulcastIdx
+ : 0;
+ IvfFileWriter* file_writer;
+ {
+ if (file_writers_[layer] == nullptr) {
+ std::ostringstream oss;
+ oss << "send_bitstream_ssrc";
+ for (uint32_t ssrc : config_.rtp.ssrcs)
+ oss << "_" << ssrc;
+ oss << "_layer" << layer << ".ivf";
+ file_writers_[layer] =
+ IvfFileWriter::Open(oss.str(), codec_specific_info->codecType);
+ }
+ file_writer = file_writers_[layer].get();
+ }
+ if (file_writer) {
+ bool ok = file_writer->WriteFrame(encoded_image);
+ RTC_DCHECK(ok);
+ }
+ }
+
+ return return_value;
}
void VideoSendStream::ConfigureProtection() {

Powered by Google App Engine
This is Rietveld 408576698