Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1936443002: Fixed rtcp rpsi parsing of invalid packets. (Closed)

Created:
4 years, 7 months ago by danilchap
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@51
Target Ref:
refs/pending/branch-heads/51
Project:
webrtc
Visibility:
Public.

Description

Fixed rtcp rpsi parsing of invalid packets. Added packet type RpsiItem to destinguish parsed rpsi header and Rpsi body preventing handling two half-valid (header-only) rpsi packets as one valid, making test parser calculate rpsi packet once instead of twice. Added check padding bits doesn't exceed native bit string length. Marking rpsi received moved after it is validated. BUG=chromium:600977 R=asapersson@webrtc.org, pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c7bb9e52402c1eeeadee0264c5c6b4a2e6fdb31d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -4 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.cc View 1 chunk +9 lines, -1 line 0 comments Download
M webrtc/test/rtcp_packet_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
danilchap
This is merge of the https://codereview.webrtc.org/1880443002/ into M51
4 years, 7 months ago (2016-04-29 08:17:09 UTC) #3
pbos-webrtc
lgtm
4 years, 7 months ago (2016-05-02 00:17:15 UTC) #4
åsapersson
lgtm
4 years, 7 months ago (2016-05-02 10:18:46 UTC) #5
danilchap
4 years, 7 months ago (2016-05-02 10:29:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7bb9e52402c1eeeadee0264c5c6b4a2e6fdb31d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698