Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1935893002: Replace scoped_ptr with unique_ptr in webrtc/libjingle/ (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/libjingle/ But keep #including scoped_ptr.h in .h files, so as not to break WebRTC users who expect those .h files to give them rtc::scoped_ptr. BUG=webrtc:5520 Committed: https://crrev.com/322c4a0b3a82caf8cdd4bf2c128c2eac72ed3058 Cr-Commit-Position: refs/heads/master@{#12577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -69 lines) Patch
M webrtc/libjingle/xmllite/xmlbuilder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlnsstack.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/chatroommoduleimpl.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/libjingle/xmpp/discoitemsquerytask.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/hangoutpubsubclient.h View 2 chunks +9 lines, -8 lines 0 comments Download
M webrtc/libjingle/xmpp/hangoutpubsubclient_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/libjingle/xmpp/iqtask.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/jingleinfotask.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/mucroomconfigtask.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/mucroomlookuptask.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/pingtask.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/pubsub_task.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/pubsubclient_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/libjingle/xmpp/pubsubstateclient.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/pubsubtasks_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/rostermodule_unittest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M webrtc/libjingle/xmpp/rostermoduleimpl.h View 4 chunks +7 lines, -5 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppclient.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/xmppclient.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppengine_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppengineimpl.h View 4 chunks +8 lines, -6 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpplogintask.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpplogintask_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpptask.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-04-30 01:20:32 UTC) #2
tommi
lgtm
4 years, 7 months ago (2016-04-30 09:17:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935893002/1
4 years, 7 months ago (2016-04-30 09:17:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-30 09:40:26 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/322c4a0b3a82caf8cdd4bf2c128c2eac72ed3058
Cr-Commit-Position: refs/heads/master@{#12577}

Powered by Google App Engine
This is Rietveld 408576698