Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1935753002: Revert of Remove VCMQmRobustness. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove VCMQmRobustness. (patchset #1 id:1 of https://codereview.webrtc.org/1917083003/ ) Reason for revert: Speculative revert for perf regression. Original issue's description: > Remove VCMQmRobustness. > > Class contained a lot of not-really-wired-up functionality that ended up > being complicated ways of saying return 1; or return false;. This > removes this dependency that complicates code readability significantly. > > BUG=webrtc:5066 > R=marpan@google.com, marpan@webrtc.org > TBR=stefan@webrtc.org > > Committed: https://crrev.com/73894369791cb5eedc8788baf918ec07d11d351d > Cr-Commit-Position: refs/heads/master@{#12516} TBR=marpan@webrtc.org,stefan@webrtc.org,marpan@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5066, chromium:607838 Committed: https://crrev.com/602316c3cd8556cc78d44f3ea4cd5fc8e70d9417 Cr-Commit-Position: refs/heads/master@{#12572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -9 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.cc View 3 chunks +28 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/qm_select.h View 1 chunk +30 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/qm_select.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pbos-webrtc
Created Revert of Remove VCMQmRobustness.
4 years, 7 months ago (2016-04-29 21:29:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935753002/1
4 years, 7 months ago (2016-04-29 21:30:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 23:10:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/602316c3cd8556cc78d44f3ea4cd5fc8e70d9417 Cr-Commit-Position: refs/heads/master@{#12572}
4 years, 7 months ago (2016-05-01 22:02:14 UTC) #8
pbos-webrtc
4 years, 7 months ago (2016-05-01 23:19:31 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1941643002/ by pbos@webrtc.org.

The reason for reverting is: Not root cause for perf regression (regression
still ongoing)..

Powered by Google App Engine
This is Rietveld 408576698