Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 1935483002: Revert of New task queueing primitive for async tasks: TaskQueue. (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of New task queueing primitive for async tasks: TaskQueue. (patchset #5 id:80001 of https://codereview.webrtc.org/1919733002/ ) Reason for revert: Reverting this temporarily while I figure out the issues with the Chrome on android GN debug build. Original issue's description: > New task queueing primitive for async tasks: TaskQueue. > TaskQueue is a new way to asynchronously execute tasks sequentially > in a thread safe manner with minimal locking. The implementation > uses OS supported APIs to do this that are compatible with async IO > notifications from things like sockets and files. > > This class is a part of rtc_base_approved, so can be used by both > the webrtc and libjingle parts of the WebRTC library. Moving forward, > we can replace rtc::Thread and webrtc::ProcessThread with this implementation. > > NOTE: It should not be assumed that all tasks that execute on a TaskQueue, > run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues > which means that tasks might execute on different threads depending on > what's the most efficient thing to do. TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b296d0591cd71baacb4ecbd1a4698a6eb2b17bca Cr-Commit-Position: refs/heads/master@{#12562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1324 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -17 lines 0 comments Download
M webrtc/base/base.gyp View 2 chunks +0 lines, -19 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/base/task_queue.h View 1 chunk +0 lines, -281 lines 0 comments Download
D webrtc/base/task_queue_gcd.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D webrtc/base/task_queue_libevent.cc View 1 chunk +0 lines, -318 lines 0 comments Download
D webrtc/base/task_queue_posix.h View 1 chunk +0 lines, -36 lines 0 comments Download
D webrtc/base/task_queue_posix.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/base/task_queue_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D webrtc/base/task_queue_win.cc View 1 chunk +0 lines, -184 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tommi
Created Revert of New task queueing primitive for async tasks: TaskQueue.
4 years, 7 months ago (2016-04-29 13:03:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935483002/1
4 years, 7 months ago (2016-04-29 13:03:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 13:03:36 UTC) #3
tommi
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1927133004/ by tommi@webrtc.org. ...
4 years, 7 months ago (2016-04-29 20:28:00 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b296d0591cd71baacb4ecbd1a4698a6eb2b17bca
Cr-Commit-Position: refs/heads/master@{#12562}

Powered by Google App Engine
This is Rietveld 408576698