Stop QuicDataChannel and QuicDataTransport unit tests from segfaulting

webrtc/api/quicdatachannel_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 149 matching lines @@
   std::map<int, rtc::scoped_refptr<QuicDataChannel>> data_channel_by_id_;
   // Last incoming QUIC stream which has arrived.
   cricket::ReliableQuicStream* incoming_stream_ = nullptr;
 };
 
 // A peer who creates a QuicDataChannel to transfer data, and simulates network
 // connectivity with a fake ICE channel wrapped by the QUIC transport channel.
 class QuicDataChannelPeer {
  public:
   QuicDataChannelPeer()
-      : ice_transport_channel_("data", 0),
-        quic_transport_channel_(&ice_transport_channel_) {
-    ice_transport_channel_.SetAsync(true);
+      : ice_transport_channel_(new FakeTransportChannel("data", 0)),
+        quic_transport_channel_(ice_transport_channel_) {
+    ice_transport_channel_->SetAsync(true);
     fake_quic_data_transport_.ConnectToTransportChannel(
         &quic_transport_channel_);
   }
 
   void GenerateCertificateAndFingerprint() {
     rtc::scoped_refptr<rtc::RTCCertificate> local_cert =
         rtc::RTCCertificate::Create(rtc::scoped_ptr<rtc::SSLIdentity>(
             rtc::SSLIdentity::Generate("cert_name", rtc::KT_DEFAULT)));
     quic_transport_channel_.SetLocalCertificate(local_cert);
     local_fingerprint_.reset(CreateFingerprint(local_cert.get()));
@@ skipping 11 matching lines @@
 
   rtc::scoped_refptr<QuicDataChannel> CreateDataChannelWithoutTransportChannel(
       int id,
       const std::string& label,
       const std::string& protocol) {
     return fake_quic_data_transport_.CreateDataChannel(id, label, protocol);
   }
 
   // Connects |ice_transport_channel_| to that of the other peer.
   void Connect(QuicDataChannelPeer* other_peer) {
-    ice_transport_channel_.Connect();
-    other_peer->ice_transport_channel_.Connect();
-    ice_transport_channel_.SetDestination(&other_peer->ice_transport_channel_);
+    ice_transport_channel_->Connect();
+    other_peer->ice_transport_channel_->Connect();
+    ice_transport_channel_->SetDestination(other_peer->ice_transport_channel_);
   }
 
   rtc::scoped_ptr<rtc::SSLFingerprint>& local_fingerprint() {
     return local_fingerprint_;
   }
 
   QuicTransportChannel* quic_transport_channel() {
     return &quic_transport_channel_;
   }
 
   FakeTransportChannel* ice_transport_channel() {
-    return &ice_transport_channel_;
+    return ice_transport_channel_;
   }
 
  private:
-  FakeTransportChannel ice_transport_channel_;
+  FakeTransportChannel* ice_transport_channel_;
   QuicTransportChannel quic_transport_channel_;
 
   rtc::scoped_ptr<rtc::SSLFingerprint> local_fingerprint_;
 
   FakeQuicDataTransport fake_quic_data_transport_;
 };
 
 class QuicDataChannelTest : public testing::Test {
  public:
   QuicDataChannelTest() {}
@@ skipping 417 matching lines @@
   size_t bytes_read2;
   ASSERT_TRUE(webrtc::ParseQuicDataMessageHeader(
       header2.data<char>(), header2.size(), &decoded_data_channel_id2,
       &decoded_message_id2, &bytes_read2));
   EXPECT_EQ(data_channel_id2, decoded_data_channel_id2);
   EXPECT_EQ(message_id2, decoded_message_id2);
   EXPECT_EQ(8u, bytes_read2);
 }
 
 }  // namespace