Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1934513002: Remove usage of VoENetwork from VoEWrapper and FakeWebRtcVoiceEngine. (Closed)

Created:
4 years, 7 months ago by the sun
Modified:
4 years, 7 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove usage of VoENetwork from VoEWrapper and FakeWebRtcVoiceEngine. BUG=webrtc:4690 Committed: https://crrev.com/05e61edd8fb37ff7a600090f03f20cdd81a401be Cr-Commit-Position: refs/heads/master@{#12566}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -52 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 4 chunks +1 line, -43 lines 0 comments Download
M webrtc/media/engine/webrtcvoe.h View 4 chunks +2 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +0 lines, -1 line 2 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
the sun
4 years, 7 months ago (2016-04-29 08:58:47 UTC) #2
ossu
lgtm but see nit So, is the VoENetwork interface just never used? https://codereview.webrtc.org/1934513002/diff/1/webrtc/media/engine/webrtcvoiceengine.cc File webrtc/media/engine/webrtcvoiceengine.cc ...
4 years, 7 months ago (2016-04-29 09:12:59 UTC) #3
the sun
Yes, VoENetwork isn't used anymore, by WVoMC. https://codereview.webrtc.org/1934513002/diff/1/webrtc/media/engine/webrtcvoiceengine.cc File webrtc/media/engine/webrtcvoiceengine.cc (left): https://codereview.webrtc.org/1934513002/diff/1/webrtc/media/engine/webrtcvoiceengine.cc#oldcode2271 webrtc/media/engine/webrtcvoiceengine.cc:2271: On 2016/04/29 ...
4 years, 7 months ago (2016-04-29 11:12:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934513002/1
4 years, 7 months ago (2016-04-29 11:12:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-04-29 13:13:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934513002/1
4 years, 7 months ago (2016-04-29 13:35:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 16:05:31 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:03 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/05e61edd8fb37ff7a600090f03f20cdd81a401be
Cr-Commit-Position: refs/heads/master@{#12566}

Powered by Google App Engine
This is Rietveld 408576698