Adds timeout for audio record thread in Java layer

Adds timeout for audio record thread in Java layer

BUG=b/28448866
R=magjed@webrtc.org

Committed: https://crrev.com/7d4a6c3208f673f735b99e60d32512873bf32fb8
Cr-Commit-Position: refs/heads/master@{#12590}

[henrika_webrtc, 2016-04-29 10:55:20]

Description was changed from

==========
Adds timeout for audio record thread in Java layer

BUG=
==========

to

==========
Adds timeout for audio record thread in Java layer

BUG=b/28448866
==========

[henrika_webrtc, 2016-04-29 10:55:20]

henrika@webrtc.org changed reviewers:
+ magjed@webrtc.org

[henrika_webrtc, 2016-04-29 10:55:49]

PTAL

[magjed_webrtc, 2016-04-29 12:02:40]

lgtm

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:23:
import org.webrtc.ThreadUtils;
nit: The imports should be in alphabetical order, so put it under Logging.

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:46:
// The AudioRecordJavaThread is allowed to wait for succesful call to join()
nit: successful, not succesful.

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:264:
Logging.e(TAG,"Join of AudioRecordJavaThread timed out");
nit: add space after 'TAG,'

[henrika_webrtc, 2016-04-29 12:23:40]

Thanks!

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:23:
import org.webrtc.ThreadUtils;
On 2016/04/29 12:02:40, magjed_webrtc wrote:
> nit: The imports should be in alphabetical order, so put it under Logging.

Done.

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:46:
// The AudioRecordJavaThread is allowed to wait for succesful call to join()
On 2016/04/29 12:02:40, magjed_webrtc wrote:
> nit: successful, not succesful.

Done.

https://codereview.webrtc.org/1933123002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:264:
Logging.e(TAG,"Join of AudioRecordJavaThread timed out");
On 2016/04/29 12:02:40, magjed_webrtc wrote:
> nit: add space after 'TAG,'

Done.

[henrika_webrtc, 2016-04-29 12:25:59]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2016-04-29 12:26:00]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1933123002/#ps20001 (title:
"nits")

[commit-bot: I haz the power, 2016-04-29 12:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933123002/20001

[commit-bot: I haz the power, 2016-04-29 12:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 12:29:34]

Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[henrika_webrtc, 2016-05-02 08:40:13]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2016-05-02 08:40:13]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1933123002/#ps40001 (title:
"moved one file")

[commit-bot: I haz the power, 2016-05-02 08:40:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933123002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933123002/40001

[commit-bot: I haz the power, 2016-05-02 08:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 08:46:51]

Try jobs failed on following builders:
  linux_ubsan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/1706)

[henrika_webrtc, 2016-05-02 09:01:11]

Description was changed from

==========
Adds timeout for audio record thread in Java layer

BUG=b/28448866
==========

to

==========
Adds timeout for audio record thread in Java layer

BUG=b/28448866
R=magjed@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7d4a6c3208f673f735b99e60d...
==========

[henrika_webrtc, 2016-05-02 09:01:13]

Committed patchset #3 (id:40001) manually as
7d4a6c3208f673f735b99e60d32512873bf32fb8 (presubmit successful).

[commit-bot: I haz the power, 2016-05-02 09:01:17]

Description was changed from

==========
Adds timeout for audio record thread in Java layer

BUG=b/28448866
R=magjed@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7d4a6c3208f673f735b99e60d...
==========

to

==========
Adds timeout for audio record thread in Java layer

BUG=b/28448866
R=magjed@webrtc.org

Committed: https://crrev.com/7d4a6c3208f673f735b99e60d32512873bf32fb8
Cr-Commit-Position: refs/heads/master@{#12590}
==========

[commit-bot: I haz the power, 2016-05-02 09:01:18]

Patchset 3 (id:??) landed as
https://crrev.com/7d4a6c3208f673f735b99e60d32512873bf32fb8
Cr-Commit-Position: refs/heads/master@{#12590}