webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc - Issue 1932683002: Remove ViEEncoder::SetNetworkStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 1932683002: Remove ViEEncoder::SetNetworkStatus (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@move_pacer

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h ('k') | webrtc/video/video_send_stream.cc » ('j') | webrtc/video/video_send_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

index f7418c1025a1589ee9545dcf94622eae9693ac47..18a143bbe22b8a000b4d179798583437517b8c6c 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

@@ -21,7 +21,8 @@ namespace bwe {

const int kFeedbackIntervalMs = 50;

FullBweSender::FullBweSender(int kbps, BitrateObserver* observer, Clock* clock)

- : bitrate_controller_(

+ : pacer_(clock, nullptr, 0),

+ bitrate_controller_(

BitrateController::CreateBitrateController(clock, observer, &pacer_)),

stefan-webrtc 2016/05/02 10:56:30 This isn't the correct pacer if a PacedVideoSender

rbe_(new RemoteBitrateEstimatorAbsSendTime(this)),

feedback_observer_(bitrate_controller_->CreateRtcpBandwidthObserver()),