Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Issue 1931933004: Reland "Avoiding overflow in cross correlation in NetEq." (Closed)

Created:
4 years, 7 months ago by minyue-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Avoiding overflow in cross correlation in NetEq." The original CL is https://codereview.webrtc.org/1908623002/ An error was caused by that and this CL fix that problem and reland the CL. BUG= Committed: https://crrev.com/53ff70f582b862c059159bf585eda688a665ed5c Cr-Commit-Position: refs/heads/master@{#12589}

Patch Set 1 : original CL #

Patch Set 2 : fixing an error #

Patch Set 3 : fixing bitexactness tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -105 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 2 2 chunks +20 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/background_noise.cc View 2 chunks +4 lines, -8 lines 0 comments Download
A webrtc/modules/audio_coding/neteq/cross_correlation.h View 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/neteq/cross_correlation.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.cc View 1 8 chunks +9 lines, -24 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/merge.h View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/merge.cc View 6 chunks +13 lines, -21 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/time_stretch.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
minyue-webrtc
Hi Henrik, This is to reland a CL you reviewed. Patch set 1 is the ...
4 years, 7 months ago (2016-05-01 16:40:20 UTC) #5
hlundin-webrtc
lgtm
4 years, 7 months ago (2016-05-02 07:48:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931933004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931933004/80001
4 years, 7 months ago (2016-05-02 07:49:08 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 7 months ago (2016-05-02 08:50:37 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 08:50:40 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/53ff70f582b862c059159bf585eda688a665ed5c
Cr-Commit-Position: refs/heads/master@{#12589}

Powered by Google App Engine
This is Rietveld 408576698