Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1930463002: Replace scoped_ptr with unique_ptr in webrtc/api/ (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/api/ But keep #including scoped_ptr.h in .h files, so as not to break WebRTC users who expect those .h files to give them rtc::scoped_ptr. BUG=webrtc:5520 Committed: https://crrev.com/d1fe281e12efd938683eae470bf01ce0d5ed3f9d Cr-Commit-Position: refs/heads/master@{#12530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -341 lines) Patch
M webrtc/api/androidvideocapturer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/api/datachannel.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/api/datachannel_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/dtlsidentitystore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/dtmfsender_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/androidmediadecoder_jni.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/java/jni/native_handle_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 11 chunks +12 lines, -13 lines 0 comments Download
M webrtc/api/jsepsessiondescription.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/jsepsessiondescription.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/jsepsessiondescription_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M webrtc/api/mediacontroller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/mediastream_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/mediastreamprovider.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/peerconnection.h View 4 chunks +9 lines, -8 lines 0 comments Download
M webrtc/api/peerconnection.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 21 chunks +28 lines, -28 lines 0 comments Download
M webrtc/api/peerconnectionendtoend_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectionfactory.h View 3 chunks +10 lines, -11 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 10 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/peerconnectionfactoryproxy.h View 5 chunks +11 lines, -10 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 43 chunks +52 lines, -53 lines 0 comments Download
M webrtc/api/proxy.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/proxy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/remoteaudiosource.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/rtpsender.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/statscollector_unittest.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/test/mockpeerconnectionobservers.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/api/videocapturertracksource.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/api/videotrack_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/api/webrtcsdp.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 7 chunks +8 lines, -10 lines 0 comments Download
M webrtc/api/webrtcsession.h View 4 chunks +9 lines, -10 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 57 chunks +88 lines, -96 lines 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-04-27 12:05:30 UTC) #2
tommi
lgtm
4 years, 7 months ago (2016-04-27 13:19:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930463002/1
4 years, 7 months ago (2016-04-27 13:26:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 13:47:35 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 13:47:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1fe281e12efd938683eae470bf01ce0d5ed3f9d
Cr-Commit-Position: refs/heads/master@{#12530}

Powered by Google App Engine
This is Rietveld 408576698