GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc}

GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc}

Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in
preparation for removing src/third_party/libjingle in Chromium.

BUG=webrtc:4256
NOTRY=True

Committed: https://crrev.com/4d02a358b4205bd0f7b5f794b6fb8c157e075b9e
Cr-Commit-Position: refs/heads/master@{#12724}

[kjellander_webrtc, 2016-05-12 13:21:34]

Patchset #3 (id:40001) has been deleted

[kjellander_webrtc, 2016-05-12 13:26:27]

Patchset #3 (id:60001) has been deleted

[kjellander_webrtc, 2016-05-12 13:26:42]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-05-12 13:26:48]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-05-13 05:56:34]

Patchset #1 (id:80001) has been deleted

[kjellander_webrtc, 2016-05-13 06:34:45]

Patchset #2 (id:120001) has been deleted

[kjellander_webrtc, 2016-05-13 06:47:43]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-05-13 06:47:43]

I'm not sure who to review this so I picked you as one on the guys benefiting
the most from getting the Chromium libjingle removal project completed :)

I don't expect you to do a side-by-side comparison between all GYP/GN files but
feel free to do so if you wish. We can always update any differences down the
road as we discover them.

[perkj_webrtc, 2016-05-13 12:41:28]

This is probably a pretty louse review. But please get it in so we can discover
any build problems.

lgtm with the below considered.

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmllite...
File webrtc/libjingle/xmllite/BUILD.gn (right):

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmllite...
webrtc/libjingle/xmllite/BUILD.gn:11: group("xmllite") {
do we really depend on xml?

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmpp/BU...
File webrtc/libjingle/xmpp/BUILD.gn (right):

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmpp/BU...
webrtc/libjingle/xmpp/BUILD.gn:33: source_set("rtc_xmpp") {
same here. Is this used?

[kjellander_webrtc, 2016-05-13 12:50:45]

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmllite...
File webrtc/libjingle/xmllite/BUILD.gn (right):

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmllite...
webrtc/libjingle/xmllite/BUILD.gn:11: group("xmllite") {
On 2016/05/13 12:41:28, perkj_webrtc wrote:
> do we really depend on xml?

Yes, webrtc/media depends on xmllite in GYP (and now its newly added BUILD.gn
file)

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmpp/BU...
File webrtc/libjingle/xmpp/BUILD.gn (right):

https://codereview.webrtc.org/1929633002/diff/140001/webrtc/libjingle/xmpp/BU...
webrtc/libjingle/xmpp/BUILD.gn:33: source_set("rtc_xmpp") {
On 2016/05/13 12:41:28, perkj_webrtc wrote:
> same here. Is this used?

Yes, webrtc/media depends on xmpp in GYP (and now its newly added BUILD.gn file)

[kjellander_webrtc, 2016-05-13 12:50:49]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-05-13 12:50:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929633002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929633002/140001

[commit-bot: I haz the power, 2016-05-13 12:52:20]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-05-13 12:52:28]

Description was changed from

==========
GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc}

Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in
preparation for removing src/third_party/libjingle in Chromium.

BUG=webrtc:4256
NOTRY=True
==========

to

==========
GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc}

Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in
preparation for removing src/third_party/libjingle in Chromium.

BUG=webrtc:4256
NOTRY=True

Committed: https://crrev.com/4d02a358b4205bd0f7b5f794b6fb8c157e075b9e
Cr-Commit-Position: refs/heads/master@{#12724}
==========

[commit-bot: I haz the power, 2016-05-13 12:52:29]

Patchset 2 (id:??) landed as
https://crrev.com/4d02a358b4205bd0f7b5f794b6fb8c157e075b9e
Cr-Commit-Position: refs/heads/master@{#12724}

[kjellander_webrtc, 2016-05-13 13:26:28]

A revert of this CL (patchset #2 id:140001) has been created in
https://codereview.webrtc.org/1977853002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks GN in Chromium..