Removed all RTP dependencies from ViEChannel and renamed class.

webrtc/video/video_receive_stream.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 153 matching lines @@
       remb_(remb),
       video_receiver_(clock_, nullptr, this, this, this),
       incoming_video_stream_(0, config.disable_prerenderer_smoothing),
       stats_proxy_(config_, clock_),
       rtp_stream_receiver_(&video_receiver_,
                            congestion_controller_->GetRemoteBitrateEstimator(
                                UseSendSideBwe(config_)),
                            &transport_adapter_,
                            call_stats_->rtcp_rtt_stats(),
                            congestion_controller_->pacer(),
-                           congestion_controller_->packet_router()),
-      vie_channel_(&video_receiver_,
-                   &rtp_stream_receiver_),
+                           congestion_controller_->packet_router(),
+                           config,
+                           &stats_proxy_,

[pbos-webrtc, 2016/05/02 00:59:02]

Can you make the RtpStreamReceiver take a stats proxy as argument instead?

[mflodman, 2016/05/02 19:01:27]

Done.

+                           &stats_proxy_,
+                           &stats_proxy_),
+      video_stream_decoder_(&video_receiver_,
+                            &rtp_stream_receiver_,

[pbos-webrtc, 2016/05/02 00:59:02]

Same here, can this take rtp_stream_receiver_ as one argument and split up
internally?

[mflodman, 2016/05/02 19:01:27]

This will very likely change to be signalled to VideoReceiveStream instead of
directly to RtpStreamReceiver, so I'd prefer to not change this. Ok?

[pbos-webrtc, 2016/05/02 20:30:30]

Gotcha, that's fine.

+                            &rtp_stream_receiver_,
+                            config.rtp.nack.rtp_history_ms > 0,
+                            &stats_proxy_),
       vie_sync_(&video_receiver_),
-      rtp_rtcp_(vie_channel_.rtp_rtcp()) {
+      rtp_rtcp_(rtp_stream_receiver_.rtp_rtcp()) {
   LOG(LS_INFO) << "VideoReceiveStream: " << config_.ToString();
 
   RTC_DCHECK(process_thread_);
   RTC_DCHECK(congestion_controller_);
   RTC_DCHECK(call_stats_);
   RTC_DCHECK(remb_);
-  RTC_CHECK(vie_channel_.Init() == 0);
-
-  // Register the channel to receive stats updates.
-  call_stats_->RegisterStatsObserver(vie_channel_.GetStatsObserver());
-
-  // TODO(pbos): This is not fine grained enough...
-  vie_channel_.SetProtectionMode(config_.rtp.nack.rtp_history_ms > 0, false, -1,
-                                 -1);
   RTC_DCHECK(config_.rtp.rtcp_mode != RtcpMode::kOff)
       << "A stream should not be configured with RTCP disabled. This value is "
          "reserved for internal usage.";
-  rtp_rtcp_->SetRTCPStatus(config_.rtp.rtcp_mode);
+
+  // Register the channel to receive stats updates.
+  call_stats_->RegisterStatsObserver(video_stream_decoder_.GetStatsObserver());
 
   RTC_DCHECK(config_.rtp.remote_ssrc != 0);
   // TODO(pbos): What's an appropriate local_ssrc for receive-only streams?
   RTC_DCHECK(config_.rtp.local_ssrc != 0);
   RTC_DCHECK(config_.rtp.remote_ssrc != config_.rtp.local_ssrc);
   rtp_rtcp_->SetSSRC(config_.rtp.local_ssrc);
 
   // TODO(pbos): Support multiple RTX, per video payload.
   for (const auto& kv : config_.rtp.rtx) {
     RTC_DCHECK(kv.second.ssrc != 0);
@@ skipping 41 matching lines @@
     if (config_.rtp.fec.red_rtx_payload_type != -1) {
       rtp_stream_receiver_.SetRtxPayloadType(
           config_.rtp.fec.red_rtx_payload_type,
           config_.rtp.fec.red_payload_type);
     }
   }
 
   if (config.rtp.rtcp_xr.receiver_reference_time_report)
     rtp_rtcp_->SetRtcpXrRrtrStatus(true);
 
-  vie_channel_.RegisterReceiveStatisticsProxy(&stats_proxy_);
-  rtp_stream_receiver_.GetReceiveStatistics()->RegisterRtpStatisticsCallback(
-      &stats_proxy_);
-  rtp_stream_receiver_.GetReceiveStatistics()->RegisterRtcpStatisticsCallback(
-      &stats_proxy_);
   // Stats callback for CNAME changes.
   rtp_rtcp_->RegisterRtcpStatisticsCallback(&stats_proxy_);
-  vie_channel_.RegisterRtcpPacketTypeCounterObserver(&stats_proxy_);
 
   RTC_DCHECK(!config_.decoders.empty());
   std::set<int> decoder_payload_types;
   for (const Decoder& decoder : config_.decoders) {
     RTC_CHECK(decoder.decoder);
     RTC_CHECK(decoder_payload_types.find(decoder.payload_type) ==
               decoder_payload_types.end())
         << "Duplicate payload type (" << decoder.payload_type
         << ") for different decoders.";
     decoder_payload_types.insert(decoder.payload_type);
     video_receiver_.RegisterExternalDecoder(decoder.decoder,
                                             decoder.payload_type);
 
     VideoCodec codec = CreateDecoderVideoCodec(decoder);
 
     RTC_CHECK(rtp_stream_receiver_.SetReceiveCodec(codec));
     RTC_CHECK_EQ(VCM_OK, video_receiver_.RegisterReceiveCodec(
                              &codec, num_cpu_cores, false));
   }
 
   video_receiver_.SetRenderDelay(config.render_delay_ms);
   incoming_video_stream_.SetExpectedRenderDelay(config.render_delay_ms);
   incoming_video_stream_.SetExternalCallback(this);
-  vie_channel_.SetIncomingVideoStream(&incoming_video_stream_);
-  vie_channel_.RegisterPreRenderCallback(this);
+  video_stream_decoder_.SetIncomingVideoStream(&incoming_video_stream_);
+  video_stream_decoder_.RegisterPreRenderCallback(this);
 
   process_thread_->RegisterModule(rtp_stream_receiver_.GetReceiveStatistics());
   process_thread_->RegisterModule(rtp_stream_receiver_.rtp_rtcp());
   process_thread_->RegisterModule(&video_receiver_);
   process_thread_->RegisterModule(&vie_sync_);
 }
 
 VideoReceiveStream::~VideoReceiveStream() {
   LOG(LS_INFO) << "~VideoReceiveStream: " << config_.ToString();
   Stop();
 
   process_thread_->DeRegisterModule(&vie_sync_);
   process_thread_->DeRegisterModule(&video_receiver_);
   process_thread_->DeRegisterModule(rtp_stream_receiver_.rtp_rtcp());
   process_thread_->DeRegisterModule(
       rtp_stream_receiver_.GetReceiveStatistics());
 
-  // Deregister external decoders so that they are no longer running during
+  // Deregister external decoders so they are no longer running during
   // destruction. This effectively stops the VCM since the decoder thread is
   // stopped, the VCM is deregistered and no asynchronous decoder threads are
   // running.
   for (const Decoder& decoder : config_.decoders)
     video_receiver_.RegisterExternalDecoder(nullptr, decoder.payload_type);
 
-  vie_channel_.RegisterPreRenderCallback(nullptr);
+  video_stream_decoder_.RegisterPreRenderCallback(nullptr);
 
-  call_stats_->DeregisterStatsObserver(vie_channel_.GetStatsObserver());
+  call_stats_->DeregisterStatsObserver(
+      video_stream_decoder_.GetStatsObserver());
   rtp_rtcp_->SetREMBStatus(false);
   remb_->RemoveReceiveChannel(rtp_rtcp_);
 
   congestion_controller_->GetRemoteBitrateEstimator(UseSendSideBwe(config_))
       ->RemoveStream(rtp_stream_receiver_.GetRemoteSsrc());
 }
 
 void VideoReceiveStream::Start() {
   if (decode_thread_.IsRunning())
     return;
@@ skipping 112 matching lines @@
     const std::vector<uint16_t>& sequence_numbers) {
   rtp_rtcp_->SendNack(sequence_numbers);
 }
 
 void VideoReceiveStream::RequestKeyFrame() {
   rtp_rtcp_->RequestKeyFrame();
 }
 
 }  // namespace internal
 }  // namespace webrtc