Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: webrtc/pc/pc.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/p2p.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/pc.gyp
diff --git a/webrtc/pc/pc.gyp b/webrtc/pc/pc.gyp
index b07f7b72638e8ed044bdf9e5abbde89ba5cbc3a9..25ebc5de78cf077db2be3d8cf0f3d20c6805b2c2 100755
--- a/webrtc/pc/pc.gyp
+++ b/webrtc/pc/pc.gyp
@@ -33,11 +33,6 @@
'defines': [
'<@(rtc_pc_defines)',
],
- # TODO(kjellander): Make the code compile without disabling these flags.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
- 'cflags_cc!': [
- '-Wnon-virtual-dtor',
- ],
'include_dirs': [
'<(DEPTH)/testing/gtest/include',
],
@@ -97,11 +92,6 @@
'rtcpmuxfilter_unittest.cc',
'srtpfilter_unittest.cc',
],
- # TODO(kjellander): Make the code compile without disabling these flags.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
- 'cflags_cc!': [
- '-Wnon-virtual-dtor',
- ],
'conditions': [
['clang==0', {
'cflags': [
« no previous file with comments | « webrtc/p2p/p2p.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698