Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/media/media.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/media/base/codec.h ('K') | « webrtc/media/engine/webrtcvideoengine2.h ('k') | webrtc/p2p/base/turnserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/media.gyp
diff --git a/webrtc/media/media.gyp b/webrtc/media/media.gyp
index 230d33ab38f0c30d6d09f4c3fb3a55b1c2c28fa5..deb730a85a8c7d2b1b16a9709df4fd42627a36a7 100644
--- a/webrtc/media/media.gyp
+++ b/webrtc/media/media.gyp
@@ -107,7 +107,6 @@
'-Wextra',
],
'cflags_cc!': [
- '-Wnon-virtual-dtor',
'-Woverloaded-virtual',
],
'msvs_disabled_warnings': [
@@ -248,11 +247,6 @@
'engine/fakewebrtcvideoengine.h',
'engine/fakewebrtcvoiceengine.h',
],
- # TODO(kjellander): Make the code compile without disabling these flags.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
- 'cflags_cc!': [
- '-Wnon-virtual-dtor',
- ],
}, # target rtc_unittest_main
{
'target_name': 'rtc_media_unittests',
@@ -291,7 +285,6 @@
'-Wno-sign-compare',
],
'cflags_cc!': [
- '-Wnon-virtual-dtor',
'-Woverloaded-virtual',
],
'msvs_disabled_warnings': [
« webrtc/media/base/codec.h ('K') | « webrtc/media/engine/webrtcvideoengine2.h ('k') | webrtc/p2p/base/turnserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698