webrtc/media/base/mediachannel.h - Issue 1928653005: Fix all -Wnon-virtual-dtor warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/mediachannel.h

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/base/mediachannel.h

diff --git a/webrtc/media/base/mediachannel.h b/webrtc/media/base/mediachannel.h

index bd1185f7220154f950604fa0cbc12c3d724e0441..7d04b1c7b5895c28588c3dce2c0598413a274c11 100644

--- a/webrtc/media/base/mediachannel.h

+++ b/webrtc/media/base/mediachannel.h

@@ -841,6 +841,7 @@ struct RtpParameters {

std::vector<RtpHeaderExtension> extensions;

// TODO(pthatcher): Add streams.

RtcpParameters rtcp;

+ virtual ~RtpParameters() = default;

};

// TODO(deadbeef): Rename to RtpSenderParameters, since they're intended to