Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/base/BUILD.gn

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/base.gyp » ('j') | webrtc/media/base/codec.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 11e886ccc0eb1fdaf7934ccc35874b56519a94a5..addc8d04258a6f3e4c59de8d6bb06ca53d719a78 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -28,12 +28,6 @@ config("rtc_base_config") {
"FEATURE_ENABLE_SSL",
"LOGGING=1",
]
-
- if (is_posix) {
- # TODO(henrike): issue 3307, make rtc_base build without disabling
- # these flags.
- cflags_cc = [ "-Wno-non-virtual-dtor" ]
- }
}
config("rtc_base_chromium_config") {
@@ -471,7 +465,6 @@ static_library("rtc_base") {
configs += [ "//build/config/compiler:no_chromium_code" ]
if (!is_win) {
cflags += [ "-Wno-uninitialized" ]
- cflags_cc += [ "-Wno-non-virtual-dtor" ]
}
if (rtc_build_ssl) {
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/base.gyp » ('j') | webrtc/media/base/codec.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698