Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: webrtc/pc/pc.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/p2p.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': ['../build/common.gypi'], 10 'includes': ['../build/common.gypi'],
(...skipping 15 matching lines...) Expand all
26 'conditions': [ 26 'conditions': [
27 ['build_libsrtp==1', { 27 ['build_libsrtp==1', {
28 'dependencies': [ 28 'dependencies': [
29 '<(DEPTH)/third_party/libsrtp/libsrtp.gyp:libsrtp', 29 '<(DEPTH)/third_party/libsrtp/libsrtp.gyp:libsrtp',
30 ], 30 ],
31 }], 31 }],
32 ], 32 ],
33 'defines': [ 33 'defines': [
34 '<@(rtc_pc_defines)', 34 '<@(rtc_pc_defines)',
35 ], 35 ],
36 # TODO(kjellander): Make the code compile without disabling these flags.
37 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
38 'cflags_cc!': [
39 '-Wnon-virtual-dtor',
40 ],
41 'include_dirs': [ 36 'include_dirs': [
42 '<(DEPTH)/testing/gtest/include', 37 '<(DEPTH)/testing/gtest/include',
43 ], 38 ],
44 'direct_dependent_settings': { 39 'direct_dependent_settings': {
45 'defines': [ 40 'defines': [
46 '<@(rtc_pc_defines)' 41 '<@(rtc_pc_defines)'
47 ], 42 ],
48 'include_dirs': [ 43 'include_dirs': [
49 '<(DEPTH)/testing/gtest/include', 44 '<(DEPTH)/testing/gtest/include',
50 ], 45 ],
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 ], 85 ],
91 'sources': [ 86 'sources': [
92 'bundlefilter_unittest.cc', 87 'bundlefilter_unittest.cc',
93 'channel_unittest.cc', 88 'channel_unittest.cc',
94 'channelmanager_unittest.cc', 89 'channelmanager_unittest.cc',
95 'currentspeakermonitor_unittest.cc', 90 'currentspeakermonitor_unittest.cc',
96 'mediasession_unittest.cc', 91 'mediasession_unittest.cc',
97 'rtcpmuxfilter_unittest.cc', 92 'rtcpmuxfilter_unittest.cc',
98 'srtpfilter_unittest.cc', 93 'srtpfilter_unittest.cc',
99 ], 94 ],
100 # TODO(kjellander): Make the code compile without disabling these flag s.
101 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
102 'cflags_cc!': [
103 '-Wnon-virtual-dtor',
104 ],
105 'conditions': [ 95 'conditions': [
106 ['clang==0', { 96 ['clang==0', {
107 'cflags': [ 97 'cflags': [
108 '-Wno-maybe-uninitialized', # Only exists for GCC. 98 '-Wno-maybe-uninitialized', # Only exists for GCC.
109 ], 99 ],
110 }], 100 }],
111 ['build_libsrtp==1', { 101 ['build_libsrtp==1', {
112 'dependencies': [ 102 'dependencies': [
113 '<(DEPTH)/third_party/libsrtp/libsrtp.gyp:libsrtp', 103 '<(DEPTH)/third_party/libsrtp/libsrtp.gyp:libsrtp',
114 ], 104 ],
(...skipping 25 matching lines...) Expand all
140 'sources': [ 130 'sources': [
141 'rtc_pc_unittests.isolate', 131 'rtc_pc_unittests.isolate',
142 ], 132 ],
143 }, 133 },
144 ], 134 ],
145 }], 135 }],
146 ], # conditions 136 ], # conditions
147 }], # include_tests==1 137 }], # include_tests==1
148 ], # conditions 138 ], # conditions
149 } 139 }
OLDNEW
« no previous file with comments | « webrtc/p2p/p2p.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698