Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: webrtc/base/base.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/libjingle/xmpp/xmpp.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 'urlencode.h', 281 'urlencode.h',
282 'worker.cc', 282 'worker.cc',
283 'worker.h', 283 'worker.h',
284 ], 284 ],
285 # TODO(henrike): issue 3307, make rtc_base build without disabling 285 # TODO(henrike): issue 3307, make rtc_base build without disabling
286 # these flags. 286 # these flags.
287 'cflags!': [ 287 'cflags!': [
288 '-Wextra', 288 '-Wextra',
289 '-Wall', 289 '-Wall',
290 ], 290 ],
291 'cflags_cc!': [
292 '-Wnon-virtual-dtor',
293 ],
294 'direct_dependent_settings': { 291 'direct_dependent_settings': {
295 'cflags_cc!': [
296 '-Wnon-virtual-dtor',
297 ],
298 'defines': [ 292 'defines': [
299 'FEATURE_ENABLE_SSL', 293 'FEATURE_ENABLE_SSL',
300 'SSL_USE_OPENSSL', 294 'SSL_USE_OPENSSL',
301 'HAVE_OPENSSL_SSL_H', 295 'HAVE_OPENSSL_SSL_H',
302 ], 296 ],
303 }, 297 },
304 'include_dirs': [ 298 'include_dirs': [
305 '../../third_party/jsoncpp/overrides/include', 299 '../../third_party/jsoncpp/overrides/include',
306 '../../third_party/jsoncpp/source/include', 300 '../../third_party/jsoncpp/source/include',
307 ], 301 ],
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 }, 601 },
608 { 602 {
609 'target_name': 'gtest_prod', 603 'target_name': 'gtest_prod',
610 'type': 'static_library', 604 'type': 'static_library',
611 'sources': [ 605 'sources': [
612 'gtest_prod_util.h', 606 'gtest_prod_util.h',
613 ], 607 ],
614 }, 608 },
615 ], 609 ],
616 } 610 }
OLDNEW
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/libjingle/xmpp/xmpp.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698