Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: webrtc/api/peerconnectionfactory_unittest.cc

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 static const char kStunIceServerWithIPv4Address[] = "stun:1.2.3.4:1234"; 57 static const char kStunIceServerWithIPv4Address[] = "stun:1.2.3.4:1234";
58 static const char kStunIceServerWithIPv4AddressWithoutPort[] = "stun:1.2.3.4"; 58 static const char kStunIceServerWithIPv4AddressWithoutPort[] = "stun:1.2.3.4";
59 static const char kStunIceServerWithIPv6Address[] = "stun:[2401:fa00:4::]:1234"; 59 static const char kStunIceServerWithIPv6Address[] = "stun:[2401:fa00:4::]:1234";
60 static const char kStunIceServerWithIPv6AddressWithoutPort[] = 60 static const char kStunIceServerWithIPv6AddressWithoutPort[] =
61 "stun:[2401:fa00:4::]"; 61 "stun:[2401:fa00:4::]";
62 static const char kTurnIceServerWithIPv6Address[] = 62 static const char kTurnIceServerWithIPv6Address[] =
63 "turn:test@[2401:fa00:4::]:1234"; 63 "turn:test@[2401:fa00:4::]:1234";
64 64
65 class NullPeerConnectionObserver : public PeerConnectionObserver { 65 class NullPeerConnectionObserver : public PeerConnectionObserver {
66 public: 66 public:
67 virtual ~NullPeerConnectionObserver() = default;
67 virtual void OnMessage(const std::string& msg) {} 68 virtual void OnMessage(const std::string& msg) {}
68 virtual void OnSignalingMessage(const std::string& msg) {} 69 virtual void OnSignalingMessage(const std::string& msg) {}
69 virtual void OnSignalingChange( 70 virtual void OnSignalingChange(
70 PeerConnectionInterface::SignalingState new_state) {} 71 PeerConnectionInterface::SignalingState new_state) {}
71 virtual void OnAddStream(MediaStreamInterface* stream) {} 72 virtual void OnAddStream(MediaStreamInterface* stream) {}
72 virtual void OnRemoveStream(MediaStreamInterface* stream) {} 73 virtual void OnRemoveStream(MediaStreamInterface* stream) {}
73 virtual void OnDataChannel(DataChannelInterface* data_channel) {} 74 virtual void OnDataChannel(DataChannelInterface* data_channel) {}
74 virtual void OnRenegotiationNeeded() {} 75 virtual void OnRenegotiationNeeded() {}
75 virtual void OnIceConnectionChange( 76 virtual void OnIceConnectionChange(
76 PeerConnectionInterface::IceConnectionState new_state) {} 77 PeerConnectionInterface::IceConnectionState new_state) {}
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 track->set_enabled(false); 348 track->set_enabled(false);
348 EXPECT_TRUE(capturer->CaptureFrame()); 349 EXPECT_TRUE(capturer->CaptureFrame());
349 EXPECT_EQ(2, local_renderer.num_rendered_frames()); 350 EXPECT_EQ(2, local_renderer.num_rendered_frames());
350 EXPECT_TRUE(local_renderer.black_frame()); 351 EXPECT_TRUE(local_renderer.black_frame());
351 352
352 track->set_enabled(true); 353 track->set_enabled(true);
353 EXPECT_TRUE(capturer->CaptureFrame()); 354 EXPECT_TRUE(capturer->CaptureFrame());
354 EXPECT_EQ(3, local_renderer.num_rendered_frames()); 355 EXPECT_EQ(3, local_renderer.num_rendered_frames());
355 EXPECT_FALSE(local_renderer.black_frame()); 356 EXPECT_FALSE(local_renderer.black_frame());
356 } 357 }
OLDNEW
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698