Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: webrtc/api/peerconnectioninterface_unittest.cc

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 409
410 MOCK_METHOD0(OnChanged, void()); 410 MOCK_METHOD0(OnChanged, void());
411 411
412 private: 412 private:
413 NotifierInterface* notifier_; 413 NotifierInterface* notifier_;
414 }; 414 };
415 415
416 class MockPeerConnectionObserver : public PeerConnectionObserver { 416 class MockPeerConnectionObserver : public PeerConnectionObserver {
417 public: 417 public:
418 MockPeerConnectionObserver() : remote_streams_(StreamCollection::Create()) {} 418 MockPeerConnectionObserver() : remote_streams_(StreamCollection::Create()) {}
419 ~MockPeerConnectionObserver() { 419 virtual ~MockPeerConnectionObserver() {
420 } 420 }
421 void SetPeerConnectionInterface(PeerConnectionInterface* pc) { 421 void SetPeerConnectionInterface(PeerConnectionInterface* pc) {
422 pc_ = pc; 422 pc_ = pc;
423 if (pc) { 423 if (pc) {
424 state_ = pc_->signaling_state(); 424 state_ = pc_->signaling_state();
425 } 425 }
426 } 426 }
427 virtual void OnSignalingChange( 427 virtual void OnSignalingChange(
428 PeerConnectionInterface::SignalingState new_state) { 428 PeerConnectionInterface::SignalingState new_state) {
429 EXPECT_EQ(pc_->signaling_state(), new_state); 429 EXPECT_EQ(pc_->signaling_state(), new_state);
(...skipping 2231 matching lines...) Expand 10 before | Expand all | Expand 10 after
2661 FakeConstraints updated_answer_c; 2661 FakeConstraints updated_answer_c;
2662 answer_c.SetMandatoryReceiveAudio(false); 2662 answer_c.SetMandatoryReceiveAudio(false);
2663 answer_c.SetMandatoryReceiveVideo(false); 2663 answer_c.SetMandatoryReceiveVideo(false);
2664 2664
2665 cricket::MediaSessionOptions updated_answer_options; 2665 cricket::MediaSessionOptions updated_answer_options;
2666 EXPECT_TRUE( 2666 EXPECT_TRUE(
2667 ParseConstraintsForAnswer(&updated_answer_c, &updated_answer_options)); 2667 ParseConstraintsForAnswer(&updated_answer_c, &updated_answer_options));
2668 EXPECT_TRUE(updated_answer_options.has_audio()); 2668 EXPECT_TRUE(updated_answer_options.has_audio());
2669 EXPECT_TRUE(updated_answer_options.has_video()); 2669 EXPECT_TRUE(updated_answer_options.has_video());
2670 } 2670 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698