Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1928543002: GN: Add -Wimplicit-fallthrough warning (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add -Wimplicit-fallthrough warning This warning was added for the GYP build back in https://webrtc-codereview.appspot.com/34899004 NOTRY=True Committed: https://crrev.com/3f032cf6882b3438adab1940fe917c39a50fabbd Cr-Commit-Position: refs/heads/master@{#12531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 7 months ago (2016-04-27 13:55:51 UTC) #2
nisse-webrtc
lgtm
4 years, 7 months ago (2016-04-27 14:02:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928543002/1
4 years, 7 months ago (2016-04-27 14:12:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 14:13:51 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 14:14:01 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3f032cf6882b3438adab1940fe917c39a50fabbd
Cr-Commit-Position: refs/heads/master@{#12531}

Powered by Google App Engine
This is Rietveld 408576698