Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1928443004: Revert of Deliver reordered packets in arrival time order after parsing feedback message. (Closed)

Created:
4 years, 7 months ago by stefan-webrtc
Modified:
4 years, 7 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Deliver reordered packets in arrival time order after parsing feedback message. (patchset #2 id:20001 of https://codereview.webrtc.org/1915993002/ ) Reason for revert: Breaks bots Original issue's description: > Deliver reordered packets in arrival time order after parsing feedback message. > > This is what the remote bitrate estimator expects. > > BUG=5823 > R=sprang@webrtc.org > > Committed: https://crrev.com/ed9535e2cac6be7a45fb03dc8426ef3b0ec43294 > Cr-Commit-Position: refs/heads/master@{#12527} TBR=sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=5823 Committed: https://crrev.com/0415a560207e2d56d7dff4ef605ceda76b8312a5 Cr-Commit-Position: refs/heads/master@{#12528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -60 lines) Patch
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 4 chunks +5 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
stefan-webrtc
Created Revert of Deliver reordered packets in arrival time order after parsing feedback message.
4 years, 7 months ago (2016-04-27 12:30:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928443004/1
4 years, 7 months ago (2016-04-27 12:30:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 12:30:28 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 12:30:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0415a560207e2d56d7dff4ef605ceda76b8312a5
Cr-Commit-Position: refs/heads/master@{#12528}

Powered by Google App Engine
This is Rietveld 408576698