Adding default_exe_manifest to some gn binaries

Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
NOTRY=True

Committed: https://crrev.com/84583e03c7b7198d9c311d49523563b5e68274a2
Cr-Commit-Position: refs/heads/master@{#12540}

[brucedawson, 2016-04-28 00:34:04]

brucedawson@chromium.org changed reviewers:
+ kjellander@webrtc.org

[brucedawson, 2016-04-28 00:34:05]

This is a boilerplate change that I've been making across Chromium in order to
better support gn builds.

PTAL.

[kjellander_webrtc, 2016-04-28 07:15:47]

Description was changed from

==========
Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
==========

to

==========
Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
NOTRY=True
==========

[kjellander_webrtc, 2016-04-28 07:19:35]

I wonder if there's a way to get things like this to be automatically set for
executables on Windows, have you talked to dpranke@ about that? 
I expect just about everyone will forget about this when writing new executable
targets (except when you copy-paste an old one).

Either way, thanks for doing this for our repo. I'll try to remember it for
future executables when we migrate more of our build to GN.

lgtm

[kjellander_webrtc, 2016-04-28 07:19:45]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-04-28 07:19:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927793002/1

[commit-bot: I haz the power, 2016-04-28 07:21:11]

Description was changed from

==========
Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
NOTRY=True
==========

to

==========
Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
NOTRY=True
==========

[commit-bot: I haz the power, 2016-04-28 07:21:12]

Committed patchset #1 (id:1)

[brucedawson, 2016-04-28 17:10:11]

On 2016/04/28 07:19:35, kjellander (webrtc) wrote:
> I wonder if there's a way to get things like this to be automatically set for
> executables on Windows, have you talked to dpranke@ about that? 
> I expect just about everyone will forget about this when writing new
executable
> targets (except when you copy-paste an old one).
> 
> Either way, thanks for doing this for our repo. I'll try to remember it for
> future executables when we migrate more of our build to GN.
> 
> lgtm

I talked about this with brettw and he figured there wasn't a clean and elegant
way to do it. Pity. But eventually copy/paste will make it the de-facto default.

[commit-bot: I haz the power, 2016-05-01 22:01:06]

Description was changed from

==========
Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
NOTRY=True
==========

to

==========
Adding default_exe_manifest to some gn binaries

gn builds are missing Windows manifests for some webrtc executables.
These manifests are necessary in order to get predictable behavior on
Windows.

BUG=602505
NOTRY=True

Committed: https://crrev.com/84583e03c7b7198d9c311d49523563b5e68274a2
Cr-Commit-Position: refs/heads/master@{#12540}
==========

[commit-bot: I haz the power, 2016-05-01 22:01:07]

Patchset 1 (id:??) landed as
https://crrev.com/84583e03c7b7198d9c311d49523563b5e68274a2
Cr-Commit-Position: refs/heads/master@{#12540}