Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1927133004: Reland of New task queueing primitive for async tasks: TaskQueue. (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
Reviewers:
phoglund, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of New task queueing primitive for async tasks: TaskQueue. (patchset #1 id:1 of https://codereview.webrtc.org/1935483002/ ) New task queueing primitive for async tasks: TaskQueue. TaskQueue is a new way to asynchronously execute tasks sequentially in a thread safe manner with minimal locking. The implementation uses OS supported APIs to do this that are compatible with async IO notifications from things like sockets and files. This class is a part of rtc_base_approved, so can be used by both the webrtc and libjingle parts of the WebRTC library. Moving forward, we can replace rtc::Thread and webrtc::ProcessThread with this implementation. NOTE: It should not be assumed that all tasks that execute on a TaskQueue, run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues which means that tasks might execute on different threads depending on what's the most efficient thing to do. TBR=perkj@webrtc.org Committed: https://crrev.com/65d1f2aba216d077c6d22488f03e56984aef1c68 Cr-Commit-Position: refs/heads/master@{#12737}

Patch Set 1 #

Patch Set 2 : Fix android debug shared chromium GN build #

Total comments: 2

Patch Set 3 : Add build_libevent build variable #

Patch Set 4 : Fix gyp gaffe #

Patch Set 5 : Fix GN gaffe! #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1323 lines, -8 lines) Patch
M webrtc/base/BUILD.gn View 1 2 3 4 3 chunks +20 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/base/task_queue.h View 1 2 1 chunk +277 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_gcd.cc View 1 chunk +167 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_libevent.cc View 1 chunk +318 lines, -0 lines 0 comments Download
A + webrtc/base/task_queue_posix.h View 1 1 chunk +22 lines, -8 lines 0 comments Download
A webrtc/base/task_queue_posix.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_unittest.cc View 1 chunk +261 lines, -0 lines 0 comments Download
A webrtc/base/task_queue_win.cc View 1 chunk +184 lines, -0 lines 0 comments Download
M webrtc/build/common.gypi View 1 2 3 4 5 6 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (11 generated)
tommi
Created Reland of New task queueing primitive for async tasks: TaskQueue.
4 years, 7 months ago (2016-04-29 20:28:01 UTC) #1
tommi
Fix android debug shared chromium GN build
4 years, 7 months ago (2016-04-29 20:30:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133004/210001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133004/210001
4 years, 7 months ago (2016-04-29 20:30:52 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/11650)
4 years, 7 months ago (2016-04-29 22:33:17 UTC) #7
phoglund
https://codereview.webrtc.org/1927133004/diff/210001/webrtc/base/base.gyp File webrtc/base/base.gyp (right): https://codereview.webrtc.org/1927133004/diff/210001/webrtc/base/base.gyp#newcode121 webrtc/base/base.gyp:121: ['OS!="win" and OS!="mac" and OS!="ios"', { Please introduce a ...
4 years, 7 months ago (2016-05-02 09:40:05 UTC) #9
tommi
Add build_libevent build variable
4 years, 7 months ago (2016-05-02 13:00:26 UTC) #10
tommi
https://codereview.webrtc.org/1927133004/diff/210001/webrtc/base/base.gyp File webrtc/base/base.gyp (right): https://codereview.webrtc.org/1927133004/diff/210001/webrtc/base/base.gyp#newcode121 webrtc/base/base.gyp:121: ['OS!="win" and OS!="mac" and OS!="ios"', { On 2016/05/02 09:40:05, ...
4 years, 7 months ago (2016-05-02 13:01:06 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133004/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133004/230001
4 years, 7 months ago (2016-05-02 13:01:16 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3624) android_dbg on ...
4 years, 7 months ago (2016-05-02 13:03:49 UTC) #15
tommi
On 2016/05/02 13:03:49, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 7 months ago (2016-05-02 13:39:23 UTC) #16
tommi
Fix gyp gaffe
4 years, 7 months ago (2016-05-02 13:47:56 UTC) #17
tommi
Fix GN gaffe!
4 years, 7 months ago (2016-05-02 13:55:54 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133004/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133004/270001
4 years, 7 months ago (2016-05-02 13:56:34 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/14380)
4 years, 7 months ago (2016-05-02 14:19:38 UTC) #22
tommi
Rebase
4 years, 7 months ago (2016-05-02 17:19:39 UTC) #23
tommi
Rebase
4 years, 7 months ago (2016-05-04 21:46:00 UTC) #24
tommi
Rebase
4 years, 7 months ago (2016-05-10 10:19:25 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927133004/330001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927133004/330001
4 years, 7 months ago (2016-05-13 17:33:30 UTC) #27
commit-bot: I haz the power
Committed patchset #8 (id:330001)
4 years, 7 months ago (2016-05-13 20:05:03 UTC) #29
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/65d1f2aba216d077c6d22488f03e56984aef1c68 Cr-Commit-Position: refs/heads/master@{#12737}
4 years, 7 months ago (2016-05-13 20:05:10 UTC) #31
tommi
4 years, 7 months ago (2016-05-13 21:33:19 UTC) #32
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:330001) has been created in
https://codereview.webrtc.org/1981573002/ by tommi@webrtc.org.

The reason for reverting is: sigh.  Have to revert again as there seems to have
have been some change made for pnacl and CrOS..

Powered by Google App Engine
This is Rietveld 408576698